scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-09-07 08:27:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

chore: address review feedback

Browse source 
- rename resolve_route catalog-instance test to describe its actual
  id-based resolution assertion
- use EnvVars::OPENAI_API_KEY instead of a raw string in the automation
  scheduler test fixture

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Bryan Helmkamp 2026-07-23 13:13:45 -04:00
parent 831b750664
commit 96102854d8
No known key found for this signature in database
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/crates/fabro-llm/src/adapter_registry.rs
View file

@ -367,7 +367,7 @@ mod tests {
}
#[test]
fn resolve_route_returns_none_for_model_from_another_catalog() {
fn resolve_route_resolves_by_id_for_model_from_another_catalog_instance() {
let other = Catalog::from_builtin().unwrap();
let model = select_from_all(&other, "gpt-5.4");
assert!(resolve_route(Catalog::builtin(), model).is_some());

3
lib/crates/fabro-server/src/server/automation_scheduler.rs
View file

@ -336,6 +336,7 @@ fn run_due_schedules_once<'a>(
mod tests {
use fabro_api::types::RunManifest;
use fabro_automation::{AutomationDraft, AutomationTarget, AutomationTrigger, ScheduleTrigger};
use fabro_static::EnvVars;
use fabro_store::ListRunsQuery;
use fabro_types::RunStatus;
use serde_json::json;
@ -428,7 +429,7 @@ mod tests {
fn test_state_with_materializer(materializer: TestAutomationRunMaterializer) -> Arc<AppState> {
TestAppStateBuilder::new()
.env_lookup(|_| None)
.vault_entries([("OPENAI_API_KEY", "test-openai-api-key")])
.vault_entries([(EnvVars::OPENAI_API_KEY, "test-openai-api-key")])
.automation_materializer(materializer)
.build()
}