From 96102854d8b00239bc0ea95bee7a9366121aaa7f Mon Sep 17 00:00:00 2001 From: Bryan Helmkamp Date: Thu, 23 Jul 2026 13:13:45 -0400 Subject: [PATCH] chore: address review feedback - rename resolve_route catalog-instance test to describe its actual id-based resolution assertion - use EnvVars::OPENAI_API_KEY instead of a raw string in the automation scheduler test fixture Co-Authored-By: Claude Fable 5 --- lib/crates/fabro-llm/src/adapter_registry.rs | 2 +- lib/crates/fabro-server/src/server/automation_scheduler.rs | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/crates/fabro-llm/src/adapter_registry.rs b/lib/crates/fabro-llm/src/adapter_registry.rs index 810f6d6f4..dd880d200 100644 --- a/lib/crates/fabro-llm/src/adapter_registry.rs +++ b/lib/crates/fabro-llm/src/adapter_registry.rs @@ -367,7 +367,7 @@ mod tests { } #[test] - fn resolve_route_returns_none_for_model_from_another_catalog() { + fn resolve_route_resolves_by_id_for_model_from_another_catalog_instance() { let other = Catalog::from_builtin().unwrap(); let model = select_from_all(&other, "gpt-5.4"); assert!(resolve_route(Catalog::builtin(), model).is_some()); diff --git a/lib/crates/fabro-server/src/server/automation_scheduler.rs b/lib/crates/fabro-server/src/server/automation_scheduler.rs index 9499d4170..0abd3e988 100644 --- a/lib/crates/fabro-server/src/server/automation_scheduler.rs +++ b/lib/crates/fabro-server/src/server/automation_scheduler.rs @@ -336,6 +336,7 @@ fn run_due_schedules_once<'a>( mod tests { use fabro_api::types::RunManifest; use fabro_automation::{AutomationDraft, AutomationTarget, AutomationTrigger, ScheduleTrigger}; + use fabro_static::EnvVars; use fabro_store::ListRunsQuery; use fabro_types::RunStatus; use serde_json::json; @@ -428,7 +429,7 @@ mod tests { fn test_state_with_materializer(materializer: TestAutomationRunMaterializer) -> Arc { TestAppStateBuilder::new() .env_lookup(|_| None) - .vault_entries([("OPENAI_API_KEY", "test-openai-api-key")]) + .vault_entries([(EnvVars::OPENAI_API_KEY, "test-openai-api-key")]) .automation_materializer(materializer) .build() }