mirror of
https://github.com/RooVetGit/Roo-Code.git
synced 2026-08-28 05:27:24 +00:00
* fix: cancel backend auto-approval timeout when auto-approve is toggled off mid-countdown (#11439) Co-authored-by: Sannidhya <sann@Sannidhyas-MacBook-Pro.local> * fix: prevent chat history loss during cloud/settings navigation (#11371) (#11372) Co-authored-by: Sannidhya <sann@Sannidhyas-MacBook-Pro.local> * fix: preserve pasted images in chatbox during chat activity (#11375) Co-authored-by: Roo Code <roomote@roocode.com> * fix: resolve chat scroll anchoring and task-switch scroll race condit… (#11385) * fix: avoid zsh process-substitution false positives in assignments (#11365) * fix(editor): make tab close best-effort in DiffViewProvider.open (#11363) * fix(checkpoints): canonicalize core.worktree comparison to prevent Windows path mismatch failures (#11346) * fix: prevent double notification sound playback (#11283) * fix: prevent false unsaved changes prompt with OpenAI Compatible headers (#8230) (#11334) fix: prevent false unsaved changes prompt with OpenAI Compatible headers Mark automatic header syncs in ApiOptions and OpenAICompatible as non-user actions (isUserAction: false) and enhance SettingsView change detection to skip automatic syncs with semantically equal values. Root cause: two components (ApiOptions and OpenAICompatible) manage openAiHeaders state and automatically sync it back on mount/remount. These syncs were treated as user changes, triggering a false dirty state. Co-authored-by: Robert McIntyre <robertjmcintyre@users.noreply.github.com> * fix: remove noisy console.warn logs from NativeToolCallParser (#11264) Remove two console.warn messages that fire excessively when loading tasks from history: - 'Attempting to finalize unknown tool call' in finalizeStreamingToolCall() - 'Received chunk for unknown tool call' in processStreamingChunk() The defensive null-return behavior is preserved; only the log output is removed. * refactor: remove footgun prompting (file-based system prompt override) (#11387) * refactor: delete orphaned per-provider caching transform files (#11388) * feat: add disabledTools setting to globally disable native tools (#11277) * feat: add disabledTools setting to globally disable native tools Add a disabledTools field to GlobalSettings that allows disabling specific native tools by name. This enables cloud agents to be configured with restricted tool access. Schema: - Add disabledTools: z.array(toolNamesSchema).optional() to globalSettingsSchema - Add disabledTools to organizationDefaultSettingsSchema.pick() - Add disabledTools to ExtensionState Pick type Prompt generation (tool filtering): - Add disabledTools to BuildToolsOptions interface - Pass disabledTools through filterSettings to filterNativeToolsForMode() - Remove disabled tools from allowedToolNames set in filterNativeToolsForMode() Execution-time validation (safety net): - Extract disabledTools from state in presentAssistantMessage - Convert disabledTools to toolRequirements format for validateToolUse() Wiring: - Add disabledTools to ClineProvider getState() and getStateToPostToWebview() - Pass disabledTools to all buildNativeToolsArrayWithRestrictions() call sites EXT-778 * fix: check toolRequirements before ALWAYS_AVAILABLE_TOOLS Moves the toolRequirements check before the ALWAYS_AVAILABLE_TOOLS early-return in isToolAllowedForMode(). This ensures disabledTools can block always-available tools (switch_mode, new_task, etc.) at execution time, making the validation layer consistent with the filtering layer. * feat: add support for .agents/skills directory (#11181) * feat: add support for .agents/skills directory This change adds support for discovering skills from the .agents/skills directory, following the Agent Skills convention for sharing skills across different AI coding tools. Priority order (later entries override earlier ones): 1. Global ~/.agents/skills (shared across AI coding tools, lowest priority) 2. Project .agents/skills 3. Global ~/.roo/skills (Roo-specific) 4. Project .roo/skills (highest priority) Changes: - Add getGlobalAgentsDirectory() and getProjectAgentsDirectoryForCwd() functions to roo-config - Update SkillsManager.getSkillsDirectories() to include .agents/skills - Update SkillsManager.setupFileWatchers() to watch .agents/skills - Add tests for new functionality * fix: clarify skill priority comment to match actual behavior * fix: clarify skill priority comment to explain Map.set replacement mechanism --------- Co-authored-by: Roo Code <roomote@roocode.com> * feat(history): render nested subtasks as recursive tree (#11299) * feat(history): render nested subtasks as recursive tree * fix(lockfile): resolve missing ai-sdk provider entry * fix: address review feedback — dedupe countAll, increase SubtaskRow max-h - HistoryView: replace local countAll with imported countAllSubtasks from types.ts - SubtaskRow: increase nested children max-h from 500px to 2000px to match TaskGroupItem * perf(refactor): consolidate getState calls in resolveWebviewView (#11320) * perf(refactor): consolidate getState calls in resolveWebviewView Replace three separate this.getState().then() calls with a single await this.getState() and destructuring. This avoids running the full getState() method (CloudService calls, ContextProxy reads, etc.) three times during webview view resolution. * fix: keep getState consolidation non-blocking to avoid delaying webview render --------- Co-authored-by: daniel-lxs <ricciodaniel98@gmail.com> * fix: harden command auto-approval against inline JS false positives (#11382) * feat: rename search_and_replace tool to edit and unify edit-family UI (#11296) * Revert "refactor: delete orphaned per-provider caching transform files (#11388)" This reverts commit13a45b0361. * chore: regenerate built-in-skills.ts with updated formatting * fix: add missing maxReadFileLine property to test baseState The ExtensionState type now requires maxReadFileLine property (added in commit63e3f769a). Update the test to include this property with the default value of -1 (unlimited reading). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * feat: add pnpm serve command for code-server development (#10964) Co-authored-by: Roo Code <roomote@roocode.com> * chore: remove Feature Request from issue template options (#11141) Co-authored-by: Roo Code <roomote@roocode.com> * refactor(docs-extractor): simplify mode to focus on raw fact extraction (#11129) * Add cli support for linux (#11167) * fix: replace heredocs with echo statements in cli-release workflow (#11168) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * Drop MacOS-13 cli support (#11169) * fix(cli): correct example in install script (#11170) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * feat: add Kimi K2.5 model to Fireworks provider (#11177) * feat(cli): improve dev experience and roo provider API key support (#11203) - Allow --api-key and ROO_API_KEY env var for the roo provider instead of requiring cloud auth token - Switch dev/start scripts to use tsx for running directly from source without building first - Fix path resolution (version.ts, extension.ts, extension-host.ts) to work from both source and bundled locations - Disable debug log file (~/.roo/cli-debug.log) unless --debug is passed - Update README with complete env var table and dev workflow docs Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * Roo Code CLI v0.0.50 (#11204) * Roo Code CLI v0.0.50 * docs(cli): add --exit-on-error to changelog --------- Co-authored-by: Roo Code <roomote@roocode.com> * feat(cli): update default model from Opus 4.5 to Opus 4.6 (#11273) Co-authored-by: Roo Code <roomote@roocode.com> * feat(web): replace Roomote Control with Linear Integration in cloud features grid (#11280) Co-authored-by: Roo Code <roomote@roocode.com> * Add linux-arm64 for the roo cli (#11314) * chore: clean up repo-facing mode rules (#11410) * Make CLI auto-approve by default with require-approval opt-in (#11424) Co-authored-by: Roo Code <roomote@roocode.com> * Add new code owners to CODEOWNERS file * Update next.js (#11108) * feat(web): Replace bespoke navigation menu with shadcn navigation menu (#11117) Co-authored-by: Roo Code <roomote@roocode.com> --------- Co-authored-by: SannidhyaSah <sah_sannidhya@outlook.com> Co-authored-by: Sannidhya <sann@Sannidhyas-MacBook-Pro.local> Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com> Co-authored-by: Roo Code <roomote@roocode.com> Co-authored-by: Hannes Rudolph <hrudolph@gmail.com> Co-authored-by: 0xMink <dennis@dennismink.com> Co-authored-by: Robert McIntyre <robertjmcintyre@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> Co-authored-by: Matt Rubens <mrubens@users.noreply.github.com> Co-authored-by: Chris Estreich <cestreich@gmail.com>
109 lines
No EOL
6.1 KiB
XML
109 lines
No EOL
6.1 KiB
XML
<common_mistakes_to_avoid>
|
||
<mode_initialization_mistakes>
|
||
- Asking "What would you like to do?" at start instead of treating the first message as the issue description
|
||
- Delaying the workflow with unnecessary questions before discovery
|
||
- Not immediately beginning codebase-aware discovery (semantic search → regex refine → read key files)
|
||
- Skipping repository detection (git + origin) before discovery or submission
|
||
- Not validating repository context before gh commands
|
||
</mode_initialization_mistakes>
|
||
|
||
<scope_mistakes>
|
||
- Submitting without explicit user confirmation ("Submit now")
|
||
- Targeting the wrong repository by relying on current directory defaults; always pass --repo OWNER/REPO detected in Step 2
|
||
- Performing PR prep, complexity estimates, or technical scoping
|
||
</scope_mistakes>
|
||
|
||
<submission_mistakes>
|
||
<mistake_block>
|
||
<mistake>Splitting final review and submission into multiple steps</mistake>
|
||
<impact>Creates redundant prompts and inconsistent state; leads to janky UX</impact>
|
||
<correct_approach>Use a single merged "Review and Submit" step offering only: Submit now, Submit now and assign to me; treat any other response as a change request</correct_approach>
|
||
</mistake_block>
|
||
<mistake_block>
|
||
<mistake>Not offering "Submit now and assign to me"</mistake>
|
||
<impact>Forces manual assignment later; reduces efficiency</impact>
|
||
<correct_approach>Provide the assignment option and use gh issue create --assignee "@me"; if that fails, immediately run gh issue edit <issue-url-or-number> --add-assignee "@me"</correct_approach>
|
||
</mistake_block>
|
||
<mistake_block>
|
||
<mistake>Using temporary files or --body-file for issue body submission</mistake>
|
||
<impact>Introduces filesystem dependencies and leaks paths; contradicts single-command policy</impact>
|
||
<correct_approach>Use inline --body with robust quoting, e.g., --body "$(printf '%s\n' "[ISSUE_BODY]")"; do not reference any file paths</correct_approach>
|
||
</mistake_block>
|
||
<mistake_block>
|
||
<mistake>Omitting --repo or relying on current directory defaults</mistake>
|
||
<impact>May submit to the wrong repository in multi-repo or worktree contexts</impact>
|
||
<correct_approach>Always pass --repo [OWNER_REPO] detected in Step 2</correct_approach>
|
||
</mistake_block>
|
||
<mistake_block>
|
||
<mistake>Attempting submission without prior repository detection</mistake>
|
||
<impact>Commands may target the wrong repo or fail</impact>
|
||
<correct_approach>Detect git repo and ensure origin is configured before any gh commands</correct_approach>
|
||
</mistake_block>
|
||
</submission_mistakes>
|
||
|
||
<sourcing_mistakes>
|
||
<mistake_block>
|
||
<mistake>Inventing or inferring “Variations tried” when the user didn’t provide any</mistake>
|
||
<impact>Misleads triage and wastes time reproducing non-existent attempts</impact>
|
||
<correct_approach>Omit the “Variations tried” line entirely unless explicitly provided; if needed, ask a targeted question first</correct_approach>
|
||
</mistake_block>
|
||
<mistake_block>
|
||
<mistake>Framing only the problem without the value/impact</mistake>
|
||
<impact>Makes prioritization harder; obscures who benefits and why it matters</impact>
|
||
<correct_approach>Pair the problem with a plain-language value statement (who, when, why it matters)</correct_approach>
|
||
</mistake_block>
|
||
<mistake_block>
|
||
<mistake>Overstating impact without user signal</mistake>
|
||
<impact>Damages credibility and misguides prioritization</impact>
|
||
<correct_approach>Use conservative, plain language; if unsure, omit severity/reach or ask a single targeted question</correct_approach>
|
||
</mistake_block>
|
||
</sourcing_mistakes>
|
||
|
||
<problem_reporting_mistakes>
|
||
- Vague descriptions like "doesn't work" without who/when impact
|
||
- Missing minimal reproduction for bugs (environment, steps, expected, actual, variations)
|
||
- Enhancement requests that skip the user goal or desired behavior in plain language
|
||
- Titles/summaries that don't quickly communicate the issue
|
||
</problem_reporting_mistakes>
|
||
|
||
<output_mistakes>
|
||
- Including code paths, line numbers, stack traces, or diffs in the final issue body
|
||
- Adding labels, metadata, or repository details to the body
|
||
- Leaving empty section placeholders instead of omitting the section
|
||
- Using technical jargon instead of plain, user-centric language
|
||
</output_mistakes>
|
||
|
||
<code_exploration_mistakes>
|
||
<mistake>Skipping semantic search and jumping straight to assumptions</mistake>
|
||
<impact>Leads to misclassification and inaccurate context</impact>
|
||
<correct_approach>
|
||
- Start with codebase_search on extracted keywords
|
||
- Refine with search_files for exact strings (errors, component names, flags)
|
||
- read_file only as needed to verify behavior; keep evidence internal
|
||
- Early-stop when hits converge or you can name the exact feature/component
|
||
- Escalate-once if signals conflict (one refined pass), then proceed
|
||
</correct_approach>
|
||
</code_exploration_mistakes>
|
||
|
||
<discrepancy_handling_mistakes>
|
||
<mistake>Accepting user claims that contradict the codebase without verification</mistake>
|
||
<impact>Produces misleading or incorrect issue framing</impact>
|
||
<correct_approach>
|
||
- Verify claims against the implementation; trace data from creation → usage
|
||
- Compare with similar working features to ground expectations
|
||
- If discrepancies arise, present concrete, plain-language examples (no code) and confirm
|
||
</correct_approach>
|
||
</discrepancy_handling_mistakes>
|
||
|
||
<questioning_mistakes>
|
||
- Asking broad, unfocused questions instead of targeted ones based on findings
|
||
- Demanding technical details from non-technical users
|
||
- Failing to provide easy, suggested answer formats (repro scaffold, goal statement)
|
||
</questioning_mistakes>
|
||
|
||
<consistency_mistakes>
|
||
- Mixing internal technical evidence into the final body
|
||
- Ignoring the issue format or adding extra sections
|
||
- Using inconsistent tone or switching between technical and non-technical language
|
||
</consistency_mistakes>
|
||
</common_mistakes_to_avoid> |