* docs: update settings.md with comprehensive steps Update the settings documentation to include all necessary steps for adding a new configuration item, including schema definitions, type definitions, and critical steps for persistence and UI display. This ensures the documentation accurately reflects the complete process required when adding new settings to the application. Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org> * docs: add style considerations for checkbox settings Add documentation about styling checkbox settings in the UI, including: - Using VSCodeCheckbox component - Proper wrapping and spacing - Consistent styling for labels and descriptions - Example implementation based on terminalPowershellCounter Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org> * docs: add comprehensive guide for adding new configuration items Add a new section to settings.md that provides a complete checklist for adding new configuration items to the system. This guide covers all aspects from UI to persistence to functionality, based on implementation experience. Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org> * docs: update settings documentation with persistence guidelines Add comprehensive guidance for ensuring settings persist across reload Include debugging steps for troubleshooting persistence issues Replace 'Avoiding Duplicates' section with more detailed information Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org> --------- Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org> Co-authored-by: Eric Wheeler <roo-code@z.ewheeler.org>
13 KiB
For All Settings
-
Add the setting to schema definitions:
- Add the item to
globalSettingsSchemainschemas/index.ts - Add the item to
globalSettingsRecordinschemas/index.ts - Example:
terminalCommandDelay: z.number().optional(),
- Add the item to
-
Add the setting to type definitions:
- Add the item to
exports/types.ts - Add the item to
exports/roo-code.d.ts - Add the setting to
shared/ExtensionMessage.ts - Add the setting to the WebviewMessage type in
shared/WebviewMessage.ts - Example:
terminalCommandDelay?: number | undefined
- Add the item to
-
Add test coverage:
- Add the setting to mockState in ClineProvider.test.ts
- Add test cases for setting persistence and state updates
- Ensure all tests pass before submitting changes
For Checkbox Settings
-
Add the message type to WebviewMessage.ts:
- Add the setting name to the WebviewMessage type's type union
- Example:
| "multisearchDiffEnabled"
-
Add the setting to ExtensionStateContext.tsx:
- Add the setting to the ExtensionStateContextType interface
- Add the setter function to the interface
- Add the setting to the initial state in useState
- Add the setting to the contextValue object
- Example:
interface ExtensionStateContextType { multisearchDiffEnabled: boolean setMultisearchDiffEnabled: (value: boolean) => void }
-
Add the setting to ClineProvider.ts:
- Add the setting name to the GlobalStateKey type union
- Add the setting to the Promise.all array in getState
- Add the setting to the return value in getState with a default value
- Add the setting to the destructured variables in getStateToPostToWebview
- Add the setting to the return value in getStateToPostToWebview
- Add a case in setWebviewMessageListener to handle the setting's message type
- Example:
case "multisearchDiffEnabled": await this.updateGlobalState("multisearchDiffEnabled", message.bool) await this.postStateToWebview() break
-
Add the checkbox UI to SettingsView.tsx:
- Import the setting and its setter from ExtensionStateContext
- Add the VSCodeCheckbox component with the setting's state and onChange handler
- Add appropriate labels and description text
- Example:
<VSCodeCheckbox checked={multisearchDiffEnabled} onChange={(e: any) => setMultisearchDiffEnabled(e.target.checked)} > <span style={{ fontWeight: "500" }}>Enable multi-search diff matching</span> </VSCodeCheckbox>
-
Add the setting to handleSubmit in SettingsView.tsx:
- Add a vscode.postMessage call to send the setting's value when clicking Save
- This step is critical for persistence - without it, the setting will not be saved when the user clicks Save
- Example:
vscode.postMessage({ type: "multisearchDiffEnabled", bool: multisearchDiffEnabled })
-
Style Considerations:
- Use the VSCodeCheckbox component from @vscode/webview-ui-toolkit/react instead of HTML input elements
- Wrap each checkbox in a div element for proper spacing
- Use a span with className="font-medium" for the checkbox label inside the VSCodeCheckbox component
- Place the description in a separate div with className="text-vscode-descriptionForeground text-sm mt-1"
- Maintain consistent spacing between configuration options
- Example:
<div> <VSCodeCheckbox checked={terminalPowershellCounter ?? true} onChange={(e: any) => setCachedStateField("terminalPowershellCounter", e.target.checked)} data-testid="terminal-powershell-counter-checkbox"> <span className="font-medium">{t("settings:terminal.powershellCounter.label")}</span> </VSCodeCheckbox> <div className="text-vscode-descriptionForeground text-sm mt-1"> {t("settings:terminal.powershellCounter.description")} </div> </div>
For Select/Dropdown Settings
-
Add the message type to WebviewMessage.ts:
- Add the setting name to the WebviewMessage type's type union
- Example:
| "preferredLanguage"
-
Add the setting to ExtensionStateContext.tsx:
- Add the setting to the ExtensionStateContextType interface
- Add the setter function to the interface
- Add the setting to the initial state in useState with a default value
- Add the setting to the contextValue object
- Example:
interface ExtensionStateContextType { preferredLanguage: string setPreferredLanguage: (value: string) => void }
-
Add the setting to ClineProvider.ts:
- Add the setting name to the GlobalStateKey type union
- Add the setting to the Promise.all array in getState
- Add the setting to the return value in getState with a default value
- Add the setting to the destructured variables in getStateToPostToWebview
- Add the setting to the return value in getStateToPostToWebview
- This step is critical for UI display - without it, the setting will not be displayed in the UI
- Add a case in setWebviewMessageListener to handle the setting's message type
- Example:
case "preferredLanguage": await this.updateGlobalState("preferredLanguage", message.text) await this.postStateToWebview() break
-
Add the select UI to SettingsView.tsx:
- Import the setting and its setter from ExtensionStateContext
- Add the select element with appropriate styling to match VSCode's theme
- Add options for the dropdown
- Add appropriate labels and description text
- Example:
<select value={preferredLanguage} onChange={(e) => setPreferredLanguage(e.target.value)} style={{ width: "100%", padding: "4px 8px", backgroundColor: "var(--vscode-input-background)", color: "var(--vscode-input-foreground)", border: "1px solid var(--vscode-input-border)", borderRadius: "2px" }}> <option value="English">English</option> <option value="Spanish">Spanish</option> ... </select>
-
Add the setting to handleSubmit in SettingsView.tsx:
- Add a vscode.postMessage call to send the setting's value when clicking Done
- Example:
vscode.postMessage({ type: "preferredLanguage", text: preferredLanguage })
These steps ensure that:
- The setting's state is properly typed throughout the application
- The setting persists between sessions
- The setting's value is properly synchronized between the webview and extension
- The setting has a proper UI representation in the settings view
- Test coverage is maintained for the new setting
Adding a New Configuration Item: Summary of Required Changes
To add a new configuration item to the system, the following changes are necessary:
-
Feature-Specific Class (if applicable)
- For settings that affect specific features (e.g., Terminal, Browser, etc.)
- Add a static property to store the value
- Add getter/setter methods to access and modify the value
-
Schema Definition
- Add the item to globalSettingsSchema in schemas/index.ts
- Add the item to globalSettingsRecord in schemas/index.ts
-
Type Definitions
- Add the item to exports/types.ts
- Add the item to exports/roo-code.d.ts
- Add the item to shared/ExtensionMessage.ts
- Add the item to shared/WebviewMessage.ts
-
UI Component
- Create or update a component in webview-ui/src/components/settings/
- Add appropriate slider/input controls with min/max/step values
- Ensure the props are passed correctly to the component in SettingsView.tsx
- Update the component's props interface to include the new settings
-
Translations
- Add label and description in webview-ui/src/i18n/locales/en/settings.json
- Update all other languages
- If any language content is changed, synchronize all other languages with that change
- Translations must be performed within "translation" mode so change modes for that purpose
-
State Management
- Add the item to the destructuring in SettingsView.tsx
- Add the item to the handleSubmit function in SettingsView.tsx
- Add the item to getStateToPostToWebview in ClineProvider.ts
- Add the item to getState in ClineProvider.ts with appropriate default values
- Add the item to the initialization in resolveWebviewView in ClineProvider.ts
-
Message Handling
- Add a case for the item in webviewMessageHandler.ts
-
Implementation-Specific Logic
- Implement any feature-specific behavior triggered by the setting
- Examples:
- Environment variables for terminal settings
- API configuration changes for provider settings
- UI behavior modifications for display settings
-
Testing
- Add test cases for the new settings in appropriate test files
- Verify settings persistence and state updates
-
Ensuring Settings Persistence Across Reload
To ensure settings persist across application reload, several key components must be properly configured:
-
Initial State in ExtensionStateContextProvider:
- Add the setting to the initial state in the useState call
- Example:
const [state, setState] = useState<ExtensionState>({ // existing settings... newSetting: false, // Default value for the new setting })
-
State Loading in ClineProvider:
- Add the setting to the getState method to load it from storage
- Example:
return { // existing settings... newSetting: stateValues.newSetting ?? false, }
-
State Initialization in resolveWebviewView:
- Add the setting to the initialization in resolveWebviewView
- Example:
this.getState().then( ({ // existing settings... newSetting, }) => { // Initialize the setting with its stored value or default FeatureClass.setNewSetting(newSetting ?? false) }, )
-
State Transmission to Webview:
- Add the setting to the getStateToPostToWebview method
- Example:
return { // existing settings... newSetting: newSetting ?? false, }
-
Setter Method in ExtensionStateContext:
- Add the setter method to the contextValue object
- Example:
const contextValue: ExtensionStateContextType = { // existing properties and methods... setNewSetting: (value) => setState((prevState) => ({ ...prevState, newSetting: value })), }
-
-
Debugging Settings Persistence Issues
If a setting is not persisting across reload, check the following:
-
Complete Chain of Persistence:
- Verify that the setting is added to all required locations:
- globalSettingsSchema and globalSettingsRecord in schemas/index.ts
- Initial state in ExtensionStateContextProvider
- getState method in ClineProvider.ts
- getStateToPostToWebview method in ClineProvider.ts
- resolveWebviewView method in ClineProvider.ts (if feature-specific)
- A break in any part of this chain can prevent persistence
- Verify that the setting is added to all required locations:
-
Default Values Consistency:
- Ensure default values are consistent across all locations
- Inconsistent defaults can cause unexpected behavior
-
Message Handling:
- Confirm the webviewMessageHandler.ts has a case for the setting
- Verify the message type matches what's sent from the UI
-
UI Integration:
- Check that the setting is included in the handleSubmit function in SettingsView.tsx
- Ensure the UI component correctly updates the state
-
Type Definitions:
- Verify the setting is properly typed in all relevant interfaces
- Check for typos in property names across different files
-
Storage Mechanism:
- For complex settings, ensure proper serialization/deserialization
- Check that the setting is being correctly stored in VSCode's globalState
These checks help identify and resolve common issues with settings persistence.
-