scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-10-06 02:47:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: address PR review feedback

Browse source 
- Change codebaseIndexEnabled default from true to false in IndexingSettings.tsx
- Remove condensingApiConfigId from settingDefaults (setting removed from schema)
This commit is contained in:
Hannes Rudolph 2026-01-23 17:58:40 -07:00
parent 763fe65bb7
commit f02913ba90
6 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/types/src/__tests__/defaults.spec.ts
View file

@ -47,7 +47,6 @@ describe("settingDefaults", () => {
expect(settingDefaults.alwaysAllowFollowupQuestions).toBe(false)
// Prompt enhancement settings
expect(settingDefaults.condensingApiConfigId).toBe("")
expect(settingDefaults.includeTaskHistoryInEnhance).toBe(true)
// UI settings

1
packages/types/src/defaults.ts
View file

@ -66,7 +66,6 @@ export const settingDefaults = {
alwaysAllowFollowupQuestions: false,
// Prompt enhancement settings
condensingApiConfigId: "",
includeTaskHistoryInEnhance: true,
// UI settings

1
src/utils/__tests__/settingsMigrations.spec.ts
View file

@ -191,7 +191,6 @@ describe("settingsMigrations", () => {
expect(v1Defaults.browserToolEnabled).toBe(true)
expect(v1Defaults.soundEnabled).toBe(true)
expect(v1Defaults.soundVolume).toBe(0.5)
expect(v1Defaults.diffEnabled).toBe(true)
expect(v1Defaults.enableCheckpoints).toBe(false)
expect(v1Defaults.checkpointTimeout).toBe(30)
expect(v1Defaults.browserViewportSize).toBe("900x600")

2
src/utils/settingsMigrations.ts
View file

@ -49,12 +49,10 @@ export const migrations: Record<number, MigrationDefinition> = {
browserToolEnabled: true,
soundEnabled: true,
soundVolume: 0.5,
diffEnabled: true,
enableCheckpoints: false,
checkpointTimeout: 30,
browserViewportSize: "900x600",
remoteBrowserEnabled: false,
fuzzyMatchThreshold: 1.0,
screenshotQuality: 75,
terminalOutputLineLimit: 500,
terminalOutputCharacterLimit: 50_000,

2
webview-ui/src/components/settings/IndexingSettings.tsx
View file

@ -40,7 +40,7 @@ export const IndexingSettings = ({ codebaseIndexConfig, onConfigChange, ...props
const { codebaseIndexModels, apiConfiguration } = useExtensionState()
// Extract values from nested config
const codebaseIndexEnabled = codebaseIndexConfig?.codebaseIndexEnabled ?? true
const codebaseIndexEnabled = codebaseIndexConfig?.codebaseIndexEnabled ?? false
const codebaseIndexQdrantUrl = codebaseIndexConfig?.codebaseIndexQdrantUrl ?? ""
const codebaseIndexEmbedderProvider = codebaseIndexConfig?.codebaseIndexEmbedderProvider ?? "openai"
const codebaseIndexEmbedderBaseUrl = codebaseIndexConfig?.codebaseIndexEmbedderBaseUrl ?? ""

4
webview-ui/src/components/settings/__tests__/IndexingSettings.spec.tsx
View file

@ -229,9 +229,9 @@ describe("IndexingSettings", () => {
<IndexingSettings codebaseIndexConfig={undefined} onConfigChange={onConfigChange} />,
)
// Should render without errors and show enable checkbox as checked by default
// Should render without errors and show enable checkbox as unchecked by default
const checkbox = getByTestId("enable-checkbox") as HTMLInputElement
expect(checkbox.checked).toBe(true)
expect(checkbox.checked).toBe(false)
})
it("updates checkbox state when prop changes", () => {