From f02913ba9069c176e41e465bcd7fea1e4d581151 Mon Sep 17 00:00:00 2001
From: Hannes Rudolph <hrudolph@gmail.com>
Date: Fri, 23 Jan 2026 17:58:40 -0700
Subject: [PATCH] fix: address PR review feedback

- Change codebaseIndexEnabled default from true to false in IndexingSettings.tsx
- Remove condensingApiConfigId from settingDefaults (setting removed from schema)
---
 packages/types/src/__tests__/defaults.spec.ts                 | 1 -
 packages/types/src/defaults.ts                                | 1 -
 src/utils/__tests__/settingsMigrations.spec.ts                | 1 -
 src/utils/settingsMigrations.ts                               | 2 --
 webview-ui/src/components/settings/IndexingSettings.tsx       | 2 +-
 .../components/settings/__tests__/IndexingSettings.spec.tsx   | 4 ++--
 6 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/packages/types/src/__tests__/defaults.spec.ts b/packages/types/src/__tests__/defaults.spec.ts
index be1d16bd99..fb7780f74f 100644
--- a/packages/types/src/__tests__/defaults.spec.ts
+++ b/packages/types/src/__tests__/defaults.spec.ts
@@ -47,7 +47,6 @@ describe("settingDefaults", () => {
 		expect(settingDefaults.alwaysAllowFollowupQuestions).toBe(false)
 
 		// Prompt enhancement settings
-		expect(settingDefaults.condensingApiConfigId).toBe("")
 		expect(settingDefaults.includeTaskHistoryInEnhance).toBe(true)
 
 		// UI settings
diff --git a/packages/types/src/defaults.ts b/packages/types/src/defaults.ts
index cf572c62b1..966fe76e41 100644
--- a/packages/types/src/defaults.ts
+++ b/packages/types/src/defaults.ts
@@ -66,7 +66,6 @@ export const settingDefaults = {
 	alwaysAllowFollowupQuestions: false,
 
 	// Prompt enhancement settings
-	condensingApiConfigId: "",
 	includeTaskHistoryInEnhance: true,
 
 	// UI settings
diff --git a/src/utils/__tests__/settingsMigrations.spec.ts b/src/utils/__tests__/settingsMigrations.spec.ts
index 3f09e65a16..6d8cb2b64c 100644
--- a/src/utils/__tests__/settingsMigrations.spec.ts
+++ b/src/utils/__tests__/settingsMigrations.spec.ts
@@ -191,7 +191,6 @@ describe("settingsMigrations", () => {
 			expect(v1Defaults.browserToolEnabled).toBe(true)
 			expect(v1Defaults.soundEnabled).toBe(true)
 			expect(v1Defaults.soundVolume).toBe(0.5)
-			expect(v1Defaults.diffEnabled).toBe(true)
 			expect(v1Defaults.enableCheckpoints).toBe(false)
 			expect(v1Defaults.checkpointTimeout).toBe(30)
 			expect(v1Defaults.browserViewportSize).toBe("900x600")
diff --git a/src/utils/settingsMigrations.ts b/src/utils/settingsMigrations.ts
index 8fb3e34ad6..500a580e74 100644
--- a/src/utils/settingsMigrations.ts
+++ b/src/utils/settingsMigrations.ts
@@ -49,12 +49,10 @@ export const migrations: Record<number, MigrationDefinition> = {
 			browserToolEnabled: true,
 			soundEnabled: true,
 			soundVolume: 0.5,
-			diffEnabled: true,
 			enableCheckpoints: false,
 			checkpointTimeout: 30,
 			browserViewportSize: "900x600",
 			remoteBrowserEnabled: false,
-			fuzzyMatchThreshold: 1.0,
 			screenshotQuality: 75,
 			terminalOutputLineLimit: 500,
 			terminalOutputCharacterLimit: 50_000,
diff --git a/webview-ui/src/components/settings/IndexingSettings.tsx b/webview-ui/src/components/settings/IndexingSettings.tsx
index bf02c8ae72..dfe45b814c 100644
--- a/webview-ui/src/components/settings/IndexingSettings.tsx
+++ b/webview-ui/src/components/settings/IndexingSettings.tsx
@@ -40,7 +40,7 @@ export const IndexingSettings = ({ codebaseIndexConfig, onConfigChange, ...props
 	const { codebaseIndexModels, apiConfiguration } = useExtensionState()
 
 	// Extract values from nested config
-	const codebaseIndexEnabled = codebaseIndexConfig?.codebaseIndexEnabled ?? true
+	const codebaseIndexEnabled = codebaseIndexConfig?.codebaseIndexEnabled ?? false
 	const codebaseIndexQdrantUrl = codebaseIndexConfig?.codebaseIndexQdrantUrl ?? ""
 	const codebaseIndexEmbedderProvider = codebaseIndexConfig?.codebaseIndexEmbedderProvider ?? "openai"
 	const codebaseIndexEmbedderBaseUrl = codebaseIndexConfig?.codebaseIndexEmbedderBaseUrl ?? ""
diff --git a/webview-ui/src/components/settings/__tests__/IndexingSettings.spec.tsx b/webview-ui/src/components/settings/__tests__/IndexingSettings.spec.tsx
index 88b701b010..83e8a3df17 100644
--- a/webview-ui/src/components/settings/__tests__/IndexingSettings.spec.tsx
+++ b/webview-ui/src/components/settings/__tests__/IndexingSettings.spec.tsx
@@ -229,9 +229,9 @@ describe("IndexingSettings", () => {
 			<IndexingSettings codebaseIndexConfig={undefined} onConfigChange={onConfigChange} />,
 		)
 
-		// Should render without errors and show enable checkbox as checked by default
+		// Should render without errors and show enable checkbox as unchecked by default
 		const checkbox = getByTestId("enable-checkbox") as HTMLInputElement
-		expect(checkbox.checked).toBe(true)
+		expect(checkbox.checked).toBe(false)
 	})
 
 	it("updates checkbox state when prop changes", () => {