mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-09-08 22:22:52 +00:00
* ci: E2E workflow, web typecheck job, pre-commit hook, test suite CI: - ci.yml consolidated to reference ci-tests.yml - ci-quality.yml: add typecheck-web job for gitnexus-web/ - ci-e2e.yml: E2E workflow with dorny/paths-filter (web changes only) - ci-report.yml: remove dead integration-reports references - CI gate allows skipped E2E status - .gitignore: playwright artifacts, eval test artifacts Pre-commit hook: - .githooks/pre-commit: typecheck + unit tests for both packages - Activated via git config core.hooksPath in prepare script Test infrastructure: - Vitest + React Testing Library: 58 unit tests (graph, server-connection, mermaid, settings, constants, utils, paths) - Playwright E2E: 5 tests + manual recording harness - vitest.config from vitest/config, engines.node >= 20 - Playwright artifacts retain-on-failure - wait-on in devDependencies - vitest/coverage-v8 aligned with vitest 4.x Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: update gitnexus-web package-lock.json Reflects devDependency additions (vitest, playwright, wait-on, @testing-library, etc.) from package.json changes in this PR. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(e2e): add missing process-list-loaded testid, increase CI timeouts - Add data-testid="process-list-loaded" to ProcessesPanel (E2E tests were waiting for an element that didn't exist) - Increase server connect timeouts from 5s to 10s for slower CI Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(ci): run gitnexus-web unit tests in CI, remove unused variable - Add gitnexus-web npm ci + vitest run to ci-tests.yml so web unit tests are gated by the CI status check (were only running locally) - Remove unused IS_PLAYWRIGHT_AUTOMATION variable from E2E spec Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(e2e): add process-row testid, wait for networkidle on page load - Add data-testid="process-row" to ProcessItem component (E2E tests referenced it but it didn't exist in the source) - Use waitUntil: 'networkidle' on page.goto to ensure Vite dev server is fully ready before interacting (fixes first-test timeout in CI) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(e2e): add process-view-button and process-highlight-button testids E2E tests referenced these data-testid attributes but they didn't exist in ProcessItem. All 6 E2E testids now have matching source elements: status-ready, process-list-loaded, process-row, process-view-button, process-highlight-button, server-url-input. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(e2e): remove networkidle — Vite HMR WebSocket prevents it from resolving networkidle waits for zero network activity for 500ms, but Vite's HMR WebSocket stays open permanently, causing page.goto to timeout at 60s on all tests after the first. The explicit toBeVisible waits on UI elements are sufficient and deterministic. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(e2e): wait for Server button visibility, add CI retry, all 5 tests pass locally Root cause: test 1 clicked the Server button before React hydrated, so the tab content never rendered and the input wasn't found. Fixes: - Wait for Server button toBeVisible before clicking - Increase input wait to 15s - Remove networkidle (Vite HMR WebSocket prevents it from resolving) - Add retries: 1 in CI for transient cold-start flakiness Verified locally: all 5 E2E tests pass, 198 unit tests pass, typecheck clean. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(ci): tolerate LadybugDB native crash during analyze step gitnexus analyze can crash with "double free or corruption" (known issue #273) during the LadybugDB native addon shutdown. The index is usually written successfully before the crash. The workflow now: 1. Allows analyze to exit non-zero with a warning 2. Verifies .gitnexus index was actually created 3. Only fails if no index exists (real failure) All tests verified locally: 198 unit, 5 E2E pass, typecheck clean. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(ci): fix shell quoting in analyze step, simplify to || true The previous echo string had special characters that broke bash quoting in GitHub Actions. Simplified to: analyze || true, then check if .gitnexus exists. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * docs: add agent development framework, GitHub templates, eval refactor Agent framework (layered docs for AI-assisted contributions): - AGENTS.md: canonical instructions, impact analysis, MCP tools - CLAUDE.md: Claude Code-specific deltas and hooks - GUARDRAILS.md: safety boundaries, non-negotiables, escalation - ARCHITECTURE.md: monorepo layout, data flow map - TESTING.md: test structure, commands, categories - RUNBOOK.md: copy-paste operations for dev/CI/MCP - llms.txt: minimal LLM context pointer Editor integration: - .cursor/index.mdc + rules/100-monorepo.mdc GitHub templates: - PR template with areas-touched checkboxes - Bug report + feature request issue forms Eval harness: - Refactored mcp_bridge, tool_registry, constants - Error sanitization utilities - Property-based tests via Hypothesis Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(eval): use format_exception instead of format_exc in sanitize_exception format_exc() returns the currently handled exception traceback, which may be unrelated if called outside an active except block. Using format_exception(type(exc), exc, exc.__traceback__) reliably captures the passed exception's traceback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * docs: update CONTRIBUTING.md and TESTING.md for current CI/hook setup - CONTRIBUTING.md: add gitnexus-web typecheck command, pre-commit hook checklist item - TESTING.md: add gitnexus-web typecheck command, pre-commit hook section (husky), update CI integration to list actual workflow files (ci-quality, ci-tests, ci-e2e) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * docs: update testing docs to reflect CI/E2E changes from PR #486 - AGENTS.md: update test counts (CLI ~2000 unit, ~1850 integration), add gitnexus-web testing section (198 unit, 5 E2E with commands) - RUNBOOK.md: fix Node requirement to >=20, fix E2E local repro command - TESTING.md: E2E uses data-testid selectors + real servers, not mocks - .cursor/rules/100-monorepo.mdc: add web test/E2E commands Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * docs: address context engineering review — deduplicate tokens, expand Cursor rules - Remove ~100-line gitnexus:start block from CLAUDE.md (was duplicated from AGENTS.md) - Fix gitnexus:start block inlined inside AGENTS.md Reference Docs bullet (doubled) - Replace CLAUDE.md scope table with pointer to AGENTS.md (single source of truth) - Expand .cursor/index.mdc with 5 non-negotiable safety rules for always-on context - Add .cursor/rules/200-eval.mdc with Python/eval commands (glob-scoped to eval/**) - Improve llms.txt with priority annotations and descriptions - Bump version headers to 1.2.0, last-reviewed to 2026-03-24 Saves ~1,400 tokens/session with zero information loss. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Gergő Magyar <gergomagyar@icloud.com>
214 lines
8 KiB
Markdown
214 lines
8 KiB
Markdown
# GitNexus SWE-bench Evaluation Harness
|
|
|
|
Evaluate whether GitNexus code intelligence improves AI agent performance on real software engineering tasks. Runs SWE-bench instances across multiple models and compares baseline (no graph) vs GitNexus-enhanced configurations.
|
|
|
|
## What This Tests
|
|
|
|
**Hypothesis**: Giving AI agents structural code intelligence (call graphs, execution flows, blast radius analysis) improves their ability to resolve real GitHub issues — measured by resolve rate, cost, and efficiency.
|
|
|
|
**Evaluation modes:**
|
|
|
|
| Mode | What the agent gets |
|
|
|------|-------------------|
|
|
| `baseline` | Standard bash tools (grep, find, cat, sed) — control group |
|
|
| `native` | Baseline + explicit GitNexus tools via eval-server (~100ms) |
|
|
| `native_augment` | Native tools + grep results automatically enriched with graph context (**recommended**) |
|
|
|
|
> **Recommended**: Use `native_augment` mode. It mirrors the Claude Code model — the agent gets both explicit GitNexus tools (fast bash commands) AND automatic enrichment of grep results with callers, callees, and execution flows. The agent decides when to use explicit tools vs rely on enriched search output.
|
|
|
|
**Models supported:**
|
|
|
|
- Claude 3.5 Haiku, Claude Sonnet 4, Claude Opus 4
|
|
- MiniMax M1 2.5
|
|
- GLM 4.7, GLM 5
|
|
- Any model supported by litellm (add a YAML config)
|
|
|
|
## Prerequisites
|
|
|
|
- Python 3.11+
|
|
- Docker (for SWE-bench containers)
|
|
- Node.js 18+ (for GitNexus)
|
|
- API keys for your chosen models
|
|
|
|
## Setup
|
|
|
|
```bash
|
|
cd eval
|
|
|
|
# Install dependencies
|
|
pip install -e .
|
|
|
|
# Set up API keys — copy the template and fill in your keys
|
|
cp .env.example .env
|
|
# Then edit .env and paste your key(s)
|
|
```
|
|
|
|
All models are routed through **OpenRouter** by default, so a single `OPENROUTER_API_KEY` is all you need. To use provider APIs directly (Anthropic, ZhipuAI, etc.), edit the model YAML in `configs/models/` and set the corresponding key in `.env`.
|
|
|
|
```bash
|
|
# Pull SWE-bench Docker images (pulled on-demand, but you can pre-pull)
|
|
docker pull swebench/sweb.eval.x86_64.django_1776_django-16527:latest
|
|
```
|
|
|
|
### Debug logging
|
|
|
|
Set `GITNEXUS_EVAL_DEBUG=1` to include full Python tracebacks in run summaries and logs. By default, errors are sanitized to avoid leaking host paths or stack traces.
|
|
|
|
## Quick Start
|
|
|
|
### Debug a single instance
|
|
|
|
```bash
|
|
# Fastest way to verify everything works
|
|
python run_eval.py debug -m claude-haiku -i django__django-16527 --subset lite
|
|
```
|
|
|
|
### Run a single configuration
|
|
|
|
```bash
|
|
# 5 instances, Claude Sonnet, native_augment mode (default)
|
|
python run_eval.py single -m claude-sonnet --subset lite --slice 0:5
|
|
|
|
# Baseline comparison (no GitNexus)
|
|
python run_eval.py single -m claude-sonnet --mode baseline --subset lite --slice 0:5
|
|
|
|
# Full Lite benchmark, 4 parallel workers
|
|
python run_eval.py single -m claude-sonnet --subset lite -w 4
|
|
```
|
|
|
|
### Run the full matrix
|
|
|
|
```bash
|
|
# All models x all modes
|
|
python run_eval.py matrix --subset lite -w 4
|
|
|
|
# Key comparison: baseline vs native_augment
|
|
python run_eval.py matrix -m claude-sonnet -m claude-haiku --modes baseline --modes native_augment --subset lite --slice 0:50
|
|
```
|
|
|
|
### Analyze results
|
|
|
|
```bash
|
|
# Summary table
|
|
python -m analysis.analyze_results results/
|
|
|
|
# Compare modes for a specific model
|
|
python -m analysis.analyze_results compare-modes results/ -m claude-sonnet
|
|
|
|
# GitNexus tool usage analysis
|
|
python -m analysis.analyze_results gitnexus-usage results/
|
|
|
|
# Export as CSV for further analysis
|
|
python -m analysis.analyze_results summary results/ --format csv > results.csv
|
|
|
|
# Run official SWE-bench test evaluation
|
|
python -m analysis.analyze_results summary results/ --swebench-eval
|
|
```
|
|
|
|
### List available configurations
|
|
|
|
```bash
|
|
python run_eval.py list-configs
|
|
```
|
|
|
|
## Architecture
|
|
|
|
```
|
|
eval/
|
|
run_eval.py # Main entry point (single, matrix, debug commands)
|
|
agents/
|
|
gitnexus_agent.py # GitNexusAgent: extends DefaultAgent with augmentation + metrics
|
|
environments/
|
|
gitnexus_docker.py # Docker env with GitNexus + eval-server + standalone tool scripts
|
|
bridge/
|
|
gitnexus_tools.sh # Bash wrappers (legacy — now standalone scripts are installed directly)
|
|
mcp_bridge.py # Legacy MCP bridge (kept for reference)
|
|
prompts/
|
|
system_baseline.jinja # System: persona + format rules
|
|
instance_baseline.jinja # Instance: task + workflow
|
|
system_native.jinja # System: + GitNexus tool reference
|
|
instance_native.jinja # Instance: + GitNexus debugging workflow
|
|
system_native_augment.jinja # System: + GitNexus tools + grep enrichment docs
|
|
instance_native_augment.jinja # Instance: + GitNexus workflow + risk assessment
|
|
configs/
|
|
models/ # Per-model YAML configs
|
|
modes/ # Per-mode YAML configs (baseline, native, native_augment)
|
|
analysis/
|
|
analyze_results.py # Post-run comparative analysis
|
|
results/ # Output directory (gitignored)
|
|
```
|
|
|
|
## How It Works
|
|
|
|
### Template structure
|
|
|
|
mini-swe-agent requires two Jinja templates:
|
|
- **system_template** → system message: persona, format rules, tool reference (static)
|
|
- **instance_template** → first user message: task, workflow, rules, examples (contains `{{task}}`)
|
|
|
|
Each mode has a `system_{mode}.jinja` + `instance_{mode}.jinja` pair. The agent loads both automatically based on the configured mode.
|
|
|
|
### Per-instance flow
|
|
|
|
1. Docker container starts with SWE-bench instance (repo at specific commit)
|
|
2. **GitNexus setup**: Node.js + gitnexus installed, `gitnexus analyze` runs (or restores from cache)
|
|
3. **Eval-server starts**: `gitnexus eval-server` daemon (persistent HTTP server, keeps LadybugDB warm)
|
|
4. **Standalone tool scripts installed** in `/usr/local/bin/` — works with `subprocess.run` (no `.bashrc` needed)
|
|
5. Agent runs with the configured model + system prompt + GitNexus tools
|
|
6. Agent's patch is extracted as a git diff
|
|
7. Metrics collected: cost, tokens, tool calls, GitNexus usage, augmentation stats
|
|
|
|
### Tool architecture
|
|
|
|
```
|
|
Agent → bash command → /usr/local/bin/gitnexus-query
|
|
→ curl localhost:4848/tool/query (fast path: eval-server, ~100ms)
|
|
→ npx gitnexus query (fallback: cold CLI, ~5-10s)
|
|
```
|
|
|
|
Each tool script in `/usr/local/bin/` is standalone — no sourcing, no env inheritance needed. This is critical because mini-swe-agent runs every command via `subprocess.run` in a fresh subshell.
|
|
|
|
### Eval-server
|
|
|
|
The eval-server is a lightweight HTTP daemon that:
|
|
- Keeps LadybugDB warm in memory (no cold start per tool call)
|
|
- Returns LLM-friendly text (not raw JSON — saves tokens)
|
|
- Includes next-step hints to guide tool chaining (query → context → impact → fix)
|
|
- Auto-shuts down after idle timeout
|
|
|
|
### Index caching
|
|
|
|
SWE-bench repos repeat (Django has 200+ instances at different commits). The harness caches GitNexus indexes per `(repo, commit)` hash in `~/.gitnexus-eval-cache/` to avoid redundant re-indexing.
|
|
|
|
### Grep augmentation (native_augment mode)
|
|
|
|
When the agent runs `grep` or `rg`, the observation is post-processed: the agent class calls `gitnexus-augment` on the search pattern and appends `[GitNexus]` annotations showing callers, callees, and execution flows for matched symbols. This mirrors the Claude Code / Cursor hook integration.
|
|
|
|
## Adding Models
|
|
|
|
Create a YAML file in `configs/models/`:
|
|
|
|
```yaml
|
|
# configs/models/my-model.yaml
|
|
model:
|
|
model_name: "openrouter/provider/model-name"
|
|
cost_tracking: "ignore_errors" # if not in litellm's cost DB
|
|
model_kwargs:
|
|
max_tokens: 8192
|
|
temperature: 0
|
|
```
|
|
|
|
The model name follows [litellm conventions](https://docs.litellm.ai/docs/providers).
|
|
|
|
## Metrics Collected
|
|
|
|
| Metric | Description |
|
|
|--------|-------------|
|
|
| Patch Rate | % of instances where agent produced a patch |
|
|
| Resolve Rate | % of instances where patch passes tests (requires --swebench-eval) |
|
|
| Total Cost | API cost across all instances |
|
|
| Avg Cost/Instance | Cost efficiency |
|
|
| API Calls | Number of LLM calls |
|
|
| GN Tool Calls | How many GitNexus tools the agent used |
|
|
| Augment Hits | How many grep/find results got enriched |
|
|
| Augment Hit Rate | % of search commands that got useful enrichment |
|