mirror of
https://github.com/zotero/zotero.git
synced 2026-08-28 05:25:31 +00:00
31d9e89165
The item tree's DOM id carries a view-specific suffix (e.g. "item-tree-main-default", "item-tree-main-recentlyRead"), but three call sites compared against a single hardcoded "item-tree-main": - Collection highlighting on Ctrl/Option (zoteroPane.js) -- match on the "item-tree-main" prefix to cover all views. This restores highlighting in Recently Read, where it silently failed. - Focusing the items list after Add Item by Identifier (lookup.js) -- use the current view's tree id instead of a literal that resolved to null and threw. - Shift-Tab from the item tree to the toolbar (zoteroPane.js) -- key the actionsMap on the current view's tree id. Add a test confirming focus lands on the items list after a lookup. https://forums.zotero.org/discussion/130968/collection-of-selected-papers-is-not-highlighted-in-recently-read-panel
99 lines
No EOL
3.2 KiB
JavaScript
99 lines
No EOL
3.2 KiB
JavaScript
var lookupIdentifier = async function (win, identifier) {
|
|
var textbox = win.document.getElementById("zotero-lookup-textbox");
|
|
textbox.value = identifier;
|
|
var promise = waitForItemEvent("add");
|
|
await win.Zotero_Lookup.accept(textbox);
|
|
return promise;
|
|
};
|
|
|
|
describe("Add Item by Identifier", function () {
|
|
var win;
|
|
|
|
before(function* () {
|
|
if (Zotero.automatedTest) {
|
|
this.skip();
|
|
return;
|
|
}
|
|
win = yield loadZoteroPane();
|
|
});
|
|
|
|
after(function () {
|
|
if (win) {
|
|
win.close();
|
|
}
|
|
});
|
|
|
|
// TODO: mock external services: https://github.com/zotero/zotero/issues/699
|
|
|
|
it("should add an ISBN-10", function () {
|
|
this.timeout(20000);
|
|
return lookupIdentifier(win, "0838985890").then(function (ids) {
|
|
var item = Zotero.Items.get(ids[0]);
|
|
assert.match(item.getField("title"), /^Zotero: a guide for librarians, researchers/);
|
|
});
|
|
});
|
|
|
|
it("should add an ISBN-13", function () {
|
|
this.timeout(20000);
|
|
return lookupIdentifier(win, "978-0838985892").then(function (ids) {
|
|
var item = Zotero.Items.get(ids[0]);
|
|
assert.match(item.getField("title"), /^Zotero: a guide for librarians, researchers/);
|
|
});
|
|
});
|
|
|
|
it("should add a DOI", function () {
|
|
this.timeout(20000);
|
|
return lookupIdentifier(win, "10.4103/0976-500X.85940").then(function (ids) {
|
|
var item = Zotero.Items.get(ids[0]);
|
|
assert.equal(item.getField("title"), "Zotero: A bibliographic assistant to researcher");
|
|
});
|
|
});
|
|
|
|
it("should focus the items list after adding items", async function () {
|
|
// Make sure the items list is non-empty (and therefore focusable)
|
|
await createDataObject('item');
|
|
await waitForItemsLoad(win);
|
|
// Stub the lookup itself so the test doesn't hit external services
|
|
var stub = sinon.stub(win.Zotero_Lookup, "addItemsFromIdentifier").resolves([{}]);
|
|
try {
|
|
var textbox = win.document.getElementById("zotero-lookup-textbox");
|
|
await win.Zotero_Lookup.accept(textbox);
|
|
assert.equal(win.document.activeElement.id, win.ZoteroPane.itemsView.id);
|
|
}
|
|
finally {
|
|
stub.restore();
|
|
}
|
|
});
|
|
|
|
it.skip("should add a DOI with an open-access PDF");
|
|
|
|
// e.g., arXiv
|
|
it.skip("should not add a PDF if a DOI already retrieves one");
|
|
|
|
it("should add a PMID", function () {
|
|
this.timeout(10000);
|
|
return lookupIdentifier(win, "24297125").then(function (ids) {
|
|
var item = Zotero.Items.get(ids[0]);
|
|
assert.equal(item.getField("title"), "Taking control of your digital library: how modern citation managers do more than just referencing");
|
|
});
|
|
});
|
|
|
|
it("should add an item within a collection", async function () {
|
|
this.timeout(20000);
|
|
|
|
var col = await createDataObject('collection');
|
|
await select(win, col);
|
|
|
|
// Initial translator
|
|
var ids = await lookupIdentifier(win, "10.4103/0976-500X.85940");
|
|
var item = Zotero.Items.get(ids[0]);
|
|
assert.equal(item.getField("title"), "Zotero: A bibliographic assistant to researcher");
|
|
assert.isTrue(item.inCollection(col.id));
|
|
|
|
// Fallback translator
|
|
var ids = await lookupIdentifier(win, "10.5281/zenodo.55073");
|
|
var item = Zotero.Items.get(ids[0]);
|
|
assert.equal(item.getField("title"), "Comparison Of Spectral Methods Through The Adjacency Matrix And The Laplacian Of A Graph");
|
|
assert.isTrue(item.inCollection(col.id));
|
|
});
|
|
}); |