Commit graph

11721 commits

Author SHA1 Message Date
Abe Jellinek
4d90fe72bd CookieSandbox: Fix XHR interface check
Actually broken since fx115.
2024-12-16 12:21:55 -05:00
windingwind
28e7966973 Fix ZoteroPane#buildFieldTransformMenu document variable (#4927)
fix: https://groups.google.com/g/zotero-dev/c/FwfrxviKi8I
2024-12-14 01:16:06 -05:00
Adomas Ven
e3b243ba45 Remove missing-component integration error. (#4923)
This is no longer a thing since word plugins are not Zotero extensions.
If that code throws - it's because we've done something wrong and it's
a bug
2024-12-14 01:16:05 -05:00
Dan Stillman
d580e420d3 Quick fix for inconsistent logging in updates window 2024-12-14 01:16:05 -05:00
Dan Stillman
ca1e9bc467 fx128: Fix app updates 2024-12-14 01:16:05 -05:00
Dan Stillman
468155c548 fx128: Fix broken Help menu on first open on Linux
Only assign a key to "Support and Documentation" on macOS

Fixes #4918
2024-12-14 01:16:04 -05:00
Dan Stillman
fa20733353 fx128: Fix login manager for WebDAV
Only `addLogin` → `addLoginAsync` is necessary at this time, but
`findLogins` is deprecated, so switch to `searchLoginsAsync` as well.
2024-12-14 01:16:04 -05:00
Dan Stillman
4319b8d78e Revert modifyLoginAsync to modifyLogin 2024-12-14 01:16:03 -05:00
Dan Stillman
a0bdeab401 fx128: Fix login manager
Use async methods (since the sync ones seem to already be broken from JS
despite https://bugzilla.mozilla.org/show_bug.cgi?id=1832756 still being
open) and avoid loading Firefox Accounts module
2024-12-14 01:16:03 -05:00
Abe Jellinek
d9550bb5df Server: Expose actual bound port (#4903)
And:
- Use a different port for tests so server tests don't break when Zotero
  is already running
- Remove no-op httpServer.enabled pref updates in tests
   - It's already enabled, no test disables it, and any test that did
     would clean up after itself
   - Updating that pref has no effect without a separate call to
     Zotero.Server.init()
- Remove unused arg to Zotero.Server.init()
2024-12-14 01:16:03 -05:00
Abe Jellinek
b858645957 fx128: -moz-nativehyperlinktext -> LinkText (#4902) 2024-12-14 01:16:03 -05:00
Abe Jellinek
72b56e7a59 Pass BrowsingContext to nsIFilePicker init
Fixes #4892
2024-12-14 01:16:02 -05:00
Abe Jellinek
f28fa763cc DataTransfer#types: contains() -> includes()
Not sure what this was before, but it's a standard read-only array now.

Fixes #4893
2024-12-14 01:16:02 -05:00
Dan Stillman
45e681431b fx128: Remove uses of nsIDOMChromeWindow
https://bugzilla.mozilla.org/show_bug.cgi?id=1522052
2024-12-14 01:16:01 -05:00
Dan Stillman
187b1649c1 fx128: Handle changed error message for IOUtils.makeDir on broken symlink 2024-12-14 01:16:00 -05:00
Dan Stillman
24bf583b78 fx128: Remove uses of nsIScriptableUnicodeConverter
Replace convertToByteArray() and convertToInputStream()
2024-12-14 01:16:00 -05:00
Dan Stillman
6b3ea14aa1 fx128: Remove try/catch for Services.jsm not being available
Not sure if there are other errors here that we want to ignore, but the
specified one should no longer be an issue.
2024-12-14 01:16:00 -05:00
Dan Stillman
97329752a1 fx128: Remove Services.jsm imports
Now included automatically
2024-12-14 01:16:00 -05:00
Dan Stillman
7f619e3fe3 fx128: nsIOSFileConstantsService is gone 2024-12-14 01:16:00 -05:00
Dan Stillman
31bbf2acfa Update locales from Transifex 2024-12-14 01:08:36 -05:00
abaevbog
4196b61dc5
let Zotero_Tabs.undoClose reopen duplicate tabs (#4920)
Fixes: #4919
2024-12-14 00:42:56 -05:00
Tom Najdek
d3ef6cfebd
Improve importing from Mendeley
- Make the annotations importer more resilient to missing data
- Fix notebooks not being imported in some cases
- Fix an instance of a hidden browser leaked by the Mendeley Importer
2024-12-11 12:44:13 +01:00
Dan Stillman
e4f2894424 Remove debug line 2024-12-10 03:06:31 -05:00
Dan Stillman
8c58d887bf Shower nicer error for malformed WebDAV URL
We fix `://` or `//` automatically after #3483, but a leading ':'
character would still show an internal `NS_ERROR_MALFORMED_URI` error.
Instead, just say "[url] is not a valid WebDAV URL".
2024-12-10 03:06:31 -05:00
Dan Stillman
021c004923 Strip leading :// or // in WebDAV URL
Closes #3483
2024-12-10 03:06:31 -05:00
Dan Stillman
64c03792ea Reset file sync history when changing WebDAV URL
Fixes #3535
2024-12-10 03:06:30 -05:00
Dan Stillman
404fc41b88 Clear library storage version when resetting file sync history
Fixes #1753
2024-12-10 00:59:04 -05:00
windingwind
f3d274afeb
Item pane scroll pos fix after switching from note (#4897)
Follow up to #4879
fix: #4276
2024-12-09 02:26:20 -05:00
Abe Jellinek
886dbd17ff Abstract box: Use focused getter instead of :focus-within
See b4c5c5d539

Fixes #4878
2024-12-05 14:39:27 -05:00
Dan Stillman
6740115cf2 Revert "Fix Item Pane unstable rendering during scrolling (#4879)"
Regressions:

https://forums.zotero.org/discussion/120216/blinking-item-pane-when-switching-item-with-pinned-section-in-the-sidenav
https://forums.zotero.org/discussion/120217/title-field-is-not-visible-anymore-after-creating-a-new-item-if-a-section-is-pinned-in-the-sidenav

This reverts commit 4067745c7a.
2024-12-04 01:35:04 -05:00
Martynas Bagdonas
8317f77837 Trigger annotation import only for PDF attachments when creating a note
Fixes https://forums.zotero.org/discussion/120181/batch-create-note-from-annotations-for-different-attachment-types
2024-12-03 21:24:37 +00:00
Abe Jellinek
1c70e53006
Fix several automatic relinking regressions due to PathUtils (#4887) 2024-12-03 16:23:00 -05:00
Dan Stillman
6fe2772318 Update locales from Transifex 2024-12-03 16:15:48 -05:00
windingwind
4067745c7a
Fix Item Pane unstable rendering during scrolling (#4879)
Fix wrong vertical position in the Item Pane after switching from a note

fix: #4276
2024-12-02 22:42:32 -05:00
Dan Stillman
99b80723b8 Move special handling of 'timestamp' locator
Avoid "Locator 'timestamp' is empty in en-US locale" warning when
opening citation dialog after 969feb620d
2024-12-02 22:39:34 -05:00
Dan Stillman
969feb620d Add "Timestamp" to locator menu
https://forums.zotero.org/discussion/comment/480030/#Comment_480030
2024-11-30 01:47:00 -05:00
windingwind
7296583f2a
Fix item pane custom info row render after item change (#4875)
Add test for info row render after item change
fix: #4874
2024-11-29 16:18:31 -05:00
abaevbog
247826194a
fix advanced search anyField condition breakage (#4873)
Process "joinMode" before other conditions that may rely on it

Fixes: #4871

Co-authored-by: Dan Stillman <dstillman@zotero.org>
2024-11-27 23:43:09 -05:00
Dan Stillman
bacb60a103 Fix failure loading feed if no link and no url
APA feed link here:

https://forums.zotero.org/discussion/119954/issue-adding-new-feed-from-url-in-zotero-7
2024-11-26 22:44:48 -05:00
Abe Jellinek
0e2427fc9f Scaffold: Correct field help 2024-11-26 11:04:25 -05:00
Abe Jellinek
5a005b9adb Scaffold: Clean up tab select code slightly 2024-11-26 11:01:18 -05:00
Abe Jellinek
08ed672445 Update translate submodule 2024-11-26 10:48:39 -05:00
Abe Jellinek
bb0d7ab951 PageData actor: Settle for readyState "interactive"
Some pages seemingly never become "complete". "interactive" (which we
already use in TranslationChild) is equivalent to DOMContentLoaded, and
that's enough for everything PageDataChild needs to do right now.

This should make Scaffold test runs more reliable. TranslatorTester uses
{ requireSuccessfulStatus: true }, which calls the PageData actor, and
that was occasionally flaking and causing the test to time out.

Fixes #4869
2024-11-26 10:16:49 -05:00
Dan Stillman
fa822b516c Update locales from Transifex 2024-11-26 02:34:02 -05:00
abaevbog
d698287558
context notes pane focus fixes (#4864)
- shift-tab from a note row focuses section header's twisty
- tab from reader into context pane will focus search
field. Previously focused note row will be focused on tab
from a section header's twisty
- fix focus not leaving context notes pane if all
sections are collapsed
- shift-tab from sidenav will focus the last node
in the contextPane, instead of search input. That is to
have consistent tab order in each direction.

Fixes: #4858
2024-11-26 02:27:55 -05:00
Abe Jellinek
2e202a59c9 Scaffold: Debounce ESLint 2024-11-25 14:02:48 -05:00
abaevbog
f824741d07
itemTree: handle restoring child item from trash in notify (#4796)
If a child item is restored from the trash and its parent row
exists and is open, collapse the parent row and expand it
to re-render child items.

Fixes: #4791
2024-11-22 06:41:55 -05:00
Dan Stillman
9a578f8572 Update locales from Transifex and merge new English strings 2024-11-21 02:55:36 -05:00
abaevbog
a195750f31
context notes list focus handling followup (#4847)
- remember the last focused note-row in the contextPane
and, if possible, refocus it on shift-tab from sidenav, on
tab from the reader into notes pane, or on tab into the
notes list from the collapsible-section. Otherwise, focus the search input.
Per: https://github.com/zotero/zotero/pull/4837#issuecomment-2478108186

- when a note is opened in the context pane, let shift-tab
from sidenav place focus on the links-box. That way,
it is not skipped during tab navigation.

- fix focus not entering note-editor on Tab from the "Go back"
button and instead wrapping around to the current tab
2024-11-21 02:37:19 -05:00
Abe Jellinek
8c5a863aaf
macOS: Move Window → Zotero to platformKeys (#4778)
And change shortcut to Cmd-Shift-L to avoid conflicts with various
font size and zoom shortcuts.
2024-11-21 02:23:33 -05:00