Commit graph

8 commits

Author SHA1 Message Date
Dan Stillman
f8ef8e2119 Match native pop-up button metrics for menulists on macOS 26+
Some checks are pending
CI / Build, Upload (push) Waiting to run
CI / Detect changes (push) Waiting to run
CI / Test () (push) Blocked by required conditions
CI / Test (macOS NFS) (push) Blocked by required conditions
CI / Test (Windows arm64) (push) Blocked by required conditions
CI / Test (Windows x64) (push) Blocked by required conditions
CI / Utilities Tests (push) Waiting to run
Firefox has AppKit draw the menulist's capsule and chevron, but it sizes
the box and positions the label itself, using a fixed dropdown border
and the label's CSS margins. On macOS 27 (and probably 26), that left the
label closer to the edges and the chevron than in a native NSPopUpButton.
It also made the box 26.5px tall. Firefox assumes regular pop-up buttons
are 22px tall and only draws them unscaled in boxes up to 2px taller, so
it drew the control at 22px and scaled the image up, enlarging the
capsule and chevron.

Add padding to match native label insets, and trim the label's vertical
margins to keep the box at 24px, so Firefox draws the control unscaled.
The result measures the same as a native NSPopUpButton.
2026-09-28 14:49:08 -04:00
Dan Stillman
c694e88ec3 Revert "Fix cramped button and menulist labels on macOS 26+"
This reverts commit fcbc6ec1d5.
2026-09-28 11:27:41 -04:00
Dan Stillman
fcbc6ec1d5 Fix cramped button and menulist labels on macOS 26+
Firefox stopped inflating native controls on Tahoe (bug 1992898), but
still uses the old widget border sizes, so labels nearly touch the edges
of the new capsule-shaped buttons and run into menulist arrows.
2026-09-28 10:31:30 -04:00
Dan Stillman
6fbe5e4135 fx153: Match XUL boolean attributes in selectors without a value
Bug 2008041 made disabled, checked, hidden, collapsed, and selected
boolean attributes, so their value is empty and [disabled="true"] no
longer matches. Nothing sets any of them to "false", so matching on
presence alone is equivalent.
2026-08-03 11:48:40 -04:00
Abe Jellinek
e4878052aa fx140: Add draft macOS native-like textarea style
Firefox doesn't use any native textareas anymore, so I guess they just
removed/broke native textarea rendering.
2025-07-30 22:30:55 -04:00
windingwind
7833c6fc29 fx128: Fix macOS menupopup style (#4895)
fix: #4880
2024-12-14 01:16:03 -05:00
windingwind
01017e7d63
Fix prefs window style on MacOS (#4682)
Use MacOS menupopup style to prefs window
Move style mac/menupopup into mac/components
2024-09-12 05:13:19 -04:00
Abe Jellinek
82107beaa9 Fix menulist label misalignment on macOS
I think they're still slightly off center, but now they look exactly
like they do in Firefox. Dropdown labels in Apple's native macOS apps
are actually offset toward the top by a pixel or two.

Fixes #4086
2024-05-02 11:00:05 -04:00