From fd5c48ac513fb5481997327e335e21f3adbf2697 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Fri, 1 Sep 2017 13:21:43 -0400 Subject: [PATCH] Simplify Zotero.ItemTreeView.prototype.getSortedItems() --- chrome/content/zotero/xpcom/itemTreeView.js | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/chrome/content/zotero/xpcom/itemTreeView.js b/chrome/content/zotero/xpcom/itemTreeView.js index 8b1a4a0ae9..c17672c6a7 100644 --- a/chrome/content/zotero/xpcom/itemTreeView.js +++ b/chrome/content/zotero/xpcom/itemTreeView.js @@ -2308,20 +2308,11 @@ Zotero.ItemTreeView.prototype.getVisibleFields = function() { /** * Returns an array of items of visible items in current sort order * - * @param bool asIDs Return itemIDs - * @return array An array of Zotero.Item objects or itemIDs + * @param {Boolean} asIDs - Return itemIDs + * @return {Zotero.Item[]|Integer[]} - An array of Zotero.Item objects or itemIDs */ Zotero.ItemTreeView.prototype.getSortedItems = function(asIDs) { - var items = []; - for (let item of this._rows) { - if (asIDs) { - items.push(item.ref.id); - } - else { - items.push(item.ref); - } - } - return items; + return this._rows.map(row => asIDs ? row.ref.id : row.ref); }