From fbc82f687ddce6165e1974cab8fb7a238deff015 Mon Sep 17 00:00:00 2001 From: Abe Jellinek Date: Wed, 14 Feb 2024 16:38:09 -0500 Subject: [PATCH] updateLocaleList: Append menuitem to menupopup, not parent menulist Appending to the menulist sort of worked - the text of the added menuitem appeared in the menulist label, albeit off to the right - but the item didn't actually show in the menu and didn't get removed on subsequent calls. --- chrome/content/zotero/xpcom/style.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chrome/content/zotero/xpcom/style.js b/chrome/content/zotero/xpcom/style.js index 2fae90291a..39d8369e9b 100644 --- a/chrome/content/zotero/xpcom/style.js +++ b/chrome/content/zotero/xpcom/style.js @@ -598,7 +598,7 @@ Zotero.Styles = new function() { menuitem.setAttribute('label', selectLocale); menuitem.setAttribute('value', selectLocale); menuitem.setAttributeNS('zotero:', 'customLocale', true); - menulist.append(menuitem); + menulist.menupopup.append(menuitem); } return menulist.value = selectLocale;