From f12e5e6a7437c256e185e57e987e164186ed32aa Mon Sep 17 00:00:00 2001 From: Avram Lyon Date: Thu, 31 Mar 2011 14:31:07 +0000 Subject: [PATCH] Trans: More ACM fixes, now for item type. See http://forums.zotero.org/discussion/17246 --- translators/ACM.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/translators/ACM.js b/translators/ACM.js index 6f61fa9621..b43ade2ebb 100644 --- a/translators/ACM.js +++ b/translators/ACM.js @@ -80,7 +80,6 @@ function detectWeb(doc, url) { * @param url The URL of the page being scanned */ function doWeb(doc, url) { - Zotero.debug("test do"); var nsResolver = getNsResolver(doc, url); //If there are multiple pages @@ -145,6 +144,7 @@ function scrape(doc) { var tags = scrapeKeywords(doc); var attachments = scrapeAttachments(doc, url); var abs = scrapeAbstract(doc); + // Type not used, since it was less reliable than BibTeX var type = getArticleType(doc, url, nsResolver); var journal = getText("//meta[@name='citation_journal_title']/@content",doc, nsResolver); //Get the bibtex reference for this document as a string @@ -163,7 +163,9 @@ function scrape(doc) { if(abs) newItem.abstractNote = abs; newItem.tags = tags; newItem.attachments = attachments; - newItem.itemType= type; + // There were issues with grabbing type from the page; + // see http://forums.zotero.org/discussion/17246/ + //newItem.itemType= type; if (journal && journal != newItem.publicationTitle) { newItem.journalAbbreviation = newItem.publicationTitle; newItem.publicationTitle = journal; @@ -283,7 +285,7 @@ function scrapeAttachments(doc, url) { function scrapeAbstract(doc) { Zotero.debug("Scraping abstract"); var text = getText('//div[@class="flatbody" or @class="tabbody"]', doc); - return text; + return Zotero.Utilities.trimInternal(text); } /** @@ -312,7 +314,6 @@ function scrapeBibtex(url, nsResolver) { Zotero.debug("\nref : " + (ref == null ? "null":ref)); ref = Zotero.Utilities.trimInternal(ref); ref = Zotero.Utilities.trim(ref); - return ref; } return null;