scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-10-05 02:43:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Await saving of recognized parent item before moving attachment under it

Browse source 
A standalone PDF recognized by ISBN wasn't moved under the new parent
item, because the move was attempted before the item had been saved
and had an ID.

https://forums.zotero.org/discussion/133957/
This commit is contained in:
Dan Stillman 2026-09-28 09:53:25 -04:00
parent 34000fb29f
commit ebdc1287ac
2 changed files with 44 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
chrome/content/zotero/xpcom/recognizeDocument.js
View file

@ -444,7 +444,7 @@ Zotero.RecognizeDocument = new function () {
if (!newItem.language && res.language) {
newItem.setField('language', res.language);
}
newItem.saveTx();
await newItem.saveTx();
return newItem;
}
catch (e) {
@ -469,7 +469,7 @@ Zotero.RecognizeDocument = new function () {
if (!newItem.language && res.language) {
newItem.setField('language', res.language);
}
newItem.saveTx();
await newItem.saveTx();
return newItem;
}
catch (e) {
@ -520,7 +520,7 @@ Zotero.RecognizeDocument = new function () {
if (!newItem.language && res.language) {
newItem.setField('language', res.language);
}
newItem.saveTx();
await newItem.saveTx();
return newItem;
}
}

47
test/tests/recognizeDocumentTest.js
View file

@ -109,12 +109,10 @@ describe("Document Recognition", function () {
win.ZoteroPane.recognizeSelected();
var addedIDs = await waitForItemEvent("add");
var modifiedIDs = await waitForItemEvent("modify");
// Item and note
assert.lengthOf(addedIDs, 2);
var item = Zotero.Items.get(addedIDs[0]);
assert.equal(item.getField("title"), "Scaling study of an improved fermion action on quenched lattices");
assert.lengthOf(modifiedIDs, 2);
await waitForProgressWindow();
@ -141,11 +139,9 @@ describe("Document Recognition", function () {
win.ZoteroPane.recognizeSelected();
var addedIDs = await waitForItemEvent("add");
var modifiedIDs = await waitForItemEvent("modify");
// Item and note
assert.lengthOf(addedIDs, 2);
var item = Zotero.Items.get(addedIDs[0]);
assert.lengthOf(modifiedIDs, 2);
await waitForProgressWindow();
@ -169,11 +165,9 @@ describe("Document Recognition", function () {
win.ZoteroPane.recognizeSelected();
var addedIDs = await waitForItemEvent("add");
var modifiedIDs = await waitForItemEvent("modify");
// Item and note
assert.lengthOf(addedIDs, 2);
var item = Zotero.Items.get(addedIDs[0]);
assert.lengthOf(modifiedIDs, 2);
await waitForProgressWindow();
@ -207,6 +201,47 @@ describe("Document Recognition", function () {
assert.isTrue(collection.hasItem(item.id));
});
it("should recognize a standalone PDF by ISBN and make it a child of the new item", async function () {
let isbn = '9783034602891';
let baseURL = 'http://recognizer.test/';
Zotero.Prefs.set('recognize.url', baseURL);
Zotero.HTTP.mock = sinon.FakeXMLHttpRequest;
let server = sinon.fakeServer.create();
server.autoRespond = true;
server.respondWith(
'POST',
baseURL + 'recognize',
[200, { 'Content-Type': 'application/json' }, JSON.stringify({ isbn })]
);
let translateStub = sinon.stub(Zotero.Translate.Search.prototype, 'translate')
.resolves([{
itemType: 'book',
title: 'Classification of Higher Dimensional Algebraic Varieties',
ISBN: isbn,
tags: []
}]);
try {
let testdir = getTestDataDirectory();
testdir.append("recognizePDF_test_DOI.pdf");
let attachment = await Zotero.Attachments.importFromFile({ file: testdir });
win.ZoteroPane.recognizeSelected();
let addedIDs = await waitForItemEvent("add");
await waitForProgressWindow();
assert.lengthOf(addedIDs, 1);
assert.equal(attachment.parentItemID, addedIDs[0]);
}
finally {
Zotero.Prefs.clear('recognize.url');
Zotero.HTTP.mock = null;
server.restore();
translateStub.restore();
}
});
it("should recognize PDF by title and put new item in same collection in group library", async function () {
if (Zotero.automatedTest) this.skip(); // TODO: Mock services
this.timeout(30000);