scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-08-28 05:25:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Scaffold: Infer types of parameters based on naming conventions (#5038)

Browse source
This commit is contained in:
Abe Jellinek 2025-02-18 05:07:51 -05:00 • committed by GitHub
parent 239b68e6b8
commit eb30c23a0d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
17 changed files with 36 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
js-build/babel-worker.js
View file

@ -59,6 +59,23 @@ async function babelWorker(ev) {
transformed = contents.replace('globalThis.Set', 'Set')
.replace('globalThis.Map', 'Map');
}
// Patch Monaco's embedded TypeScript compiler
else if (sourcefile === 'resource/vs/language/typescript/tsWorker.js') {
// Infer types based on standard translator variable/parameter names
transformed = contents.replace('function getTypeOfSymbol(symbol) {', `function getTypeOfSymbol(symbol) {
switch (symbol.escapedName) {
case "doc":
return getGlobalType("Document", 0, true);
case "url":
return stringType;
case "checkOnly":
return booleanType;
}
`);
if (transformed.length === contents.length) {
return postError('Failed to patch tsWorker.js');
}
}
else if ('ignore' in options && options.ignore.some(ignoreGlob => multimatch(sourcefile, ignoreGlob).length)) {
transformed = contents;
@ -90,4 +107,4 @@ module.exports = babelWorker;
if (cluster.isWorker) {
process.on('message', babelWorker);
}
}

14
js-build/config.js
View file

@ -51,16 +51,9 @@ const symlinkFiles = [
'!resource/feeds/*.idl',
'!chrome/skin/default/zotero/**/*.scss',
'!resource/citeproc_rs_wasm.js',
// We only need a few Monaco languages
'!resource/vs/**/*',
'resource/vs/loader.js',
'resource/vs/editor/editor.main.{js,css,nls.js}',
'resource/vs/base/**/*',
'resource/vs/basic-languages/javascript/*.js',
'resource/vs/basic-languages/typescript/*.js',
'resource/vs/basic-languages/xml/*.js',
'resource/vs/language/typescript/*.js',
'resource/vs/language/json/*.js',
'resource/vs/**/*',
// Patched in babel-worker.js
'!resource/vs/language/typescript/tsWorker.js',
'version',
];
@ -118,6 +111,7 @@ const jsFiles = [
'resource/react-virtualized.js',
'resource/SingleFile/lib/single-file.js',
'resource/citeproc_rs_wasm.js',
'resource/vs/language/typescript/tsWorker.js',
];
const scssFiles = [

1
resource/vs
View file

@ -1 +0,0 @@
../node_modules/monaco-editor/min/vs

1
resource/vs/base/browser/ui/codicons/codicon/codicon.ttf Symbolic link
View file

@ -0,0 +1 @@
../../../../../../../node_modules/monaco-editor/min/vs/base/browser/ui/codicons/codicon/codicon.ttf

1
resource/vs/base/common/worker/simpleWorker.nls.js Symbolic link
View file

@ -0,0 +1 @@
../../../../../node_modules/monaco-editor/min/vs/base/common/worker/simpleWorker.nls.js

1
resource/vs/base/worker/workerMain.js Symbolic link
View file

@ -0,0 +1 @@
../../../../node_modules/monaco-editor/min/vs/base/worker/workerMain.js

1
resource/vs/basic-languages/javascript/javascript.js Symbolic link
View file

@ -0,0 +1 @@
../../../../node_modules/monaco-editor/min/vs/basic-languages/javascript/javascript.js

1
resource/vs/basic-languages/typescript/typescript.js Symbolic link
View file

@ -0,0 +1 @@
../../../../node_modules/monaco-editor/min/vs/basic-languages/typescript/typescript.js

1
resource/vs/basic-languages/xml/xml.js Symbolic link
View file

@ -0,0 +1 @@
../../../../node_modules/monaco-editor/min/vs/basic-languages/xml/xml.js

1
resource/vs/editor/editor.main.css Symbolic link
View file

@ -0,0 +1 @@
../../../node_modules/monaco-editor/min/vs/editor/editor.main.css

1
resource/vs/editor/editor.main.js Symbolic link
View file

@ -0,0 +1 @@
../../../node_modules/monaco-editor/min/vs/editor/editor.main.js

1
resource/vs/editor/editor.main.nls.js Symbolic link
View file

@ -0,0 +1 @@
../../../node_modules/monaco-editor/min/vs/editor/editor.main.nls.js

1
resource/vs/language/json/jsonMode.js Symbolic link
View file

@ -0,0 +1 @@
../../../../node_modules/monaco-editor/min/vs/language/json/jsonMode.js

1
resource/vs/language/json/jsonWorker.js Symbolic link
View file

@ -0,0 +1 @@
../../../../node_modules/monaco-editor/min/vs/language/json/jsonWorker.js

1
resource/vs/language/typescript/tsMode.js Symbolic link
View file

@ -0,0 +1 @@
../../../../node_modules/monaco-editor/min/vs/language/typescript/tsMode.js

1
resource/vs/language/typescript/tsWorker.js Symbolic link
View file

@ -0,0 +1 @@
../../../../node_modules/monaco-editor/dev/vs/language/typescript/tsWorker.js

1
resource/vs/loader.js Symbolic link
View file

@ -0,0 +1 @@
../../node_modules/monaco-editor/min/vs/loader.js