From d850a8be7d2e600ae1ec0ebbc44c07d37b445814 Mon Sep 17 00:00:00 2001
From: Dan Stillman <dstillman@zotero.org>
Date: Mon, 24 Oct 2022 19:52:00 -0400
Subject: [PATCH] Don't localize "Markdown" in Quick Copy settings

---
 .../content/zotero/preferences/preferences_export.jsx  | 10 ++++++++--
 .../zotero/preferences/preferences_export.xhtml        |  4 ++--
 chrome/locale/en-US/zotero/preferences.dtd             |  2 --
 chrome/locale/en-US/zotero/zotero.properties           |  1 +
 4 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/chrome/content/zotero/preferences/preferences_export.jsx b/chrome/content/zotero/preferences/preferences_export.jsx
index 066be61030..3bb3fa6101 100644
--- a/chrome/content/zotero/preferences/preferences_export.jsx
+++ b/chrome/content/zotero/preferences/preferences_export.jsx
@@ -200,12 +200,18 @@ Zotero_Preferences.Export = {
 
 		var markdownOptions = document.getElementById('noteQuickCopy-markdown-options');
 		var htmlOptions = document.getElementById('noteQuickCopy-html-options');
+		var markdownOptionsLabel = document.querySelector('#noteQuickCopy-markdown-options label');
+		var htmlOptionsLabel = document.querySelector('#noteQuickCopy-html-options label');
 		var markdownIncludeAppLinks = document.getElementById("noteQuickCopy-markdown-includeAppLinks");
 		var htmlIncludeAppLinks = document.getElementById("noteQuickCopy-html-includeAppLinks");
-
+		
+		markdownOptionsLabel.value = Zotero.Utilities.Internal.stringWithColon("Markdown");
+		htmlOptionsLabel.value = Zotero.Utilities.Internal.stringWithColon(
+			Zotero.getString('zotero.preferences.export.quickCopy.note.htmlOptions.label')
+		);
 		markdownIncludeAppLinks.label = Zotero.getString('exportOptions.includeAppLinks', Zotero.appName);
 		htmlIncludeAppLinks.label = Zotero.getString('exportOptions.includeAppLinks', Zotero.appName);
-
+		
 		if (format.id == Zotero.Translators.TRANSLATOR_ID_MARKDOWN_AND_RICH_TEXT) {
 			markdownOptions.hidden = false;
 			htmlOptions.hidden = false;
diff --git a/chrome/content/zotero/preferences/preferences_export.xhtml b/chrome/content/zotero/preferences/preferences_export.xhtml
index b7dd0e9589..f875e3aded 100644
--- a/chrome/content/zotero/preferences/preferences_export.xhtml
+++ b/chrome/content/zotero/preferences/preferences_export.xhtml
@@ -61,7 +61,7 @@
 			<tbody id="noteQuickCopy-markdown-options">
 				<tr>
 					<th>
-						<xul:label value="&zotero.preferences.quickCopy.markdown;"/>
+						<xul:label/>
 					</th>
 					<td>
 						<xul:checkbox id="noteQuickCopy-markdown-includeAppLinks"
@@ -73,7 +73,7 @@
 			<tbody id="noteQuickCopy-html-options">
 				<tr>
 					<th>
-						<xul:label value="&zotero.preferences.quickCopy.html;"/>
+						<xul:label/>
 					</th>
 					<td>
 						<xul:checkbox id="noteQuickCopy-html-includeAppLinks"
diff --git a/chrome/locale/en-US/zotero/preferences.dtd b/chrome/locale/en-US/zotero/preferences.dtd
index b473f32c0f..747b8bb78c 100644
--- a/chrome/locale/en-US/zotero/preferences.dtd
+++ b/chrome/locale/en-US/zotero/preferences.dtd
@@ -111,8 +111,6 @@
 <!ENTITY zotero.preferences.quickCopy.caption				"Quick Copy">
 <!ENTITY zotero.preferences.quickCopy.itemFormat       		"Item Format:">
 <!ENTITY zotero.preferences.quickCopy.noteFormat       		"Note Format:">
-<!ENTITY zotero.preferences.quickCopy.markdown       		"Markdown:">
-<!ENTITY zotero.preferences.quickCopy.html       		    "Rich Text/HTML:">
 <!ENTITY zotero.preferences.quickCopy.copyAsHTML			"Copy as HTML">
 <!ENTITY zotero.preferences.quickCopy.siteEditor.setings 	"Site-Specific Settings:">
 <!ENTITY zotero.preferences.quickCopy.siteEditor.domainPath "Domain/Path">
diff --git a/chrome/locale/en-US/zotero/zotero.properties b/chrome/locale/en-US/zotero/zotero.properties
index ccaf1c2713..6c633ec114 100644
--- a/chrome/locale/en-US/zotero/zotero.properties
+++ b/chrome/locale/en-US/zotero/zotero.properties
@@ -735,6 +735,7 @@ zotero.preferences.export.quickCopy.citationStyles        = Citation Styles
 zotero.preferences.export.quickCopy.exportFormats			= Export Formats
 zotero.preferences.export.quickCopy.instructions			= Quick Copy allows you to quickly export items in a given format. You can copy selected items to the clipboard by pressing %S or drag items directly into a text box in another program.
 zotero.preferences.export.quickCopy.citationInstructions  = For citation styles, you can copy citations or footnotes by pressing %S or holding down Shift before dragging items.
+zotero.preferences.export.quickCopy.note.htmlOptions.label  = Rich Text/HTML
 
 zotero.preferences.wordProcessors.installationSuccess		= Installation was successful.
 zotero.preferences.wordProcessors.installationError			= Installation could not be completed because an error occurred. Please ensure that %1$S is closed, and then restart %2$S.