From d4905854eb2a3e0a12a47627b691b3fbfedfa0b0 Mon Sep 17 00:00:00 2001
From: abaevbog <bogdan@zotero.org>
Date: Tue, 16 Apr 2024 00:51:49 -0400
Subject: [PATCH] vpat 18: added aria labels to inputs in settings (#3985)

---
 .../content/zotero/preferences/preferences_general.xhtml  | 7 ++++---
 chrome/content/zotero/preferences/preferences_sync.xhtml  | 8 ++++----
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/chrome/content/zotero/preferences/preferences_general.xhtml b/chrome/content/zotero/preferences/preferences_general.xhtml
index db2a78476e..2698f907f8 100644
--- a/chrome/content/zotero/preferences/preferences_general.xhtml
+++ b/chrome/content/zotero/preferences/preferences_general.xhtml
@@ -172,8 +172,9 @@
 			</hbox>
 			
 			<hbox style="display: flex; align-items: center;">
-				<label value="&zotero.preferences.openurl.server;"/>
+				<label id="openUrl-label" value="&zotero.preferences.openurl.server;"/>
 				<html:input type="text" id="openURLServerField" style="flex: 1;"
+					aria-labelledby="openURLServerField"
 					oninput="Zotero_Preferences.General.onOpenURLCustomized();"
 					preference="extensions.zotero.openURL.resolver"
 				/>
@@ -198,8 +199,8 @@
 			
 			<checkbox label="&zotero.preferences.automaticTags;" preference="extensions.zotero.automaticTags" native="true"/>
 			<hbox align="center">
-				<label value="&zotero.preferences.trashAutoEmptyDaysPre;"/>
-				<html:input type="text" size="2" preference="extensions.zotero.trashAutoEmptyDays"/>
+				<label id="trashAutoEmpty-label" value="&zotero.preferences.trashAutoEmptyDaysPre;"/>
+				<html:input aria-labelledby="trashAutoEmpty-label" type="text" size="2" preference="extensions.zotero.trashAutoEmptyDays"/>
 				<label value="&zotero.preferences.trashAutoEmptyDaysPost;"/>
 			</hbox>
 		</groupbox>
diff --git a/chrome/content/zotero/preferences/preferences_sync.xhtml b/chrome/content/zotero/preferences/preferences_sync.xhtml
index 20bf03e881..e5b40b66a7 100644
--- a/chrome/content/zotero/preferences/preferences_sync.xhtml
+++ b/chrome/content/zotero/preferences/preferences_sync.xhtml
@@ -30,15 +30,15 @@
 
                 <hbox>
                     <html:div class="form-grid">
-                        <label value="&zotero.preferences.sync.username;"/>
-                        <html:input id="sync-username-textbox"
+                        <label id="username-label" value="&zotero.preferences.sync.username;"/>
+                        <html:input id="sync-username-textbox" aria-labelledby="username-label"
                             onblur="Zotero_Preferences.Sync.trimUsername()"
                             oninput="Zotero_Preferences.Sync.credentialsChange(event)"
                             onchange="Zotero_Preferences.Sync.credentialsChange(event)"
                             onkeypress="Zotero_Preferences.Sync.credentialsKeyPress(event)"/>
                         
-                        <label value="&zotero.preferences.sync.password;"/>
-                        <html:input id="sync-password" type="password"
+                        <label id="password-label" value="&zotero.preferences.sync.password;"/>
+                        <html:input id="sync-password" type="password" aria-labelledby="password-label"
                             oninput="Zotero_Preferences.Sync.credentialsChange(event)"
                             onchange="Zotero_Preferences.Sync.credentialsChange(event)"
                             onkeypress="Zotero_Preferences.Sync.credentialsKeyPress(event)"/>