scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-10-06 02:50:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix the window lookup for OS keystore alerts

Browse source 
'zotero:main' isn't a registered window type, so the lookup always
returned null and the alerts were never shown.

https://forums.zotero.org/discussion/133418/
This commit is contained in:
Dan Stillman 2026-08-29 12:06:43 -04:00
parent bccaf46ff2
commit d276ec19c5
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
chrome/content/zotero/xpcom/osKeyStore.js
View file

@ -56,9 +56,16 @@ Zotero.OSKeyStore = {
return typeof value == 'string' && value.startsWith(this._prefix);
},
// The settings window, where credentials are usually saved from, or the main window when
// they're saved during a sync
_getParentWindow: function () {
return Services.wm.getMostRecentWindow('zotero:pref')
|| Services.wm.getMostRecentWindow('navigator:browser');
},
// Show an alert when an active write of new credentials fails (e.g., keychain unavailable)
alertSaveFailed: function () {
let win = Services.wm.getMostRecentWindow('zotero:main');
let win = this._getParentWindow();
if (!win) {
return;
}
@ -78,7 +85,7 @@ Zotero.OSKeyStore = {
return;
}
this._migrateAlertShown = true;
let win = Services.wm.getMostRecentWindow('zotero:main');
let win = this._getParentWindow();
if (!win) {
return;
}