From ce60ce90f62d2751aa2f9b4ecaf77cdd78ab2060 Mon Sep 17 00:00:00 2001
From: Dan Stillman <dstillman@zotero.org>
Date: Thu, 2 Feb 2023 23:41:09 -0500
Subject: [PATCH] Add PDF reader tab title pref to General pane

---
 .../zotero/preferences/preferences_general.xul  | 17 +++++++++++++++++
 chrome/locale/en-US/zotero/preferences.dtd      |  5 +++++
 2 files changed, 22 insertions(+)

diff --git a/chrome/content/zotero/preferences/preferences_general.xul b/chrome/content/zotero/preferences/preferences_general.xul
index 289aaf2fab..3bffad900e 100644
--- a/chrome/content/zotero/preferences/preferences_general.xul
+++ b/chrome/content/zotero/preferences/preferences_general.xul
@@ -40,6 +40,8 @@
 			<preference id="pref-automaticTags" name="extensions.zotero.automaticTags" type="bool"/>
 			<preference id="pref-trashAutoEmptyDays" name="extensions.zotero.trashAutoEmptyDays" type="int"/>
 			
+			<preference id="pref-reader-tabs-title" name="extensions.zotero.tabs.title.reader" type="string"/>
+			
 			<preference id="pref-groups-copyChildNotes" name="extensions.zotero.groups.copyChildNotes" type="bool"/>
 			<preference id="pref-groups-copyChildFileAttachments" name="extensions.zotero.groups.copyChildFileAttachments" type="bool"/>
 			<preference id="pref-groups-copyAnnotations" name="extensions.zotero.groups.copyAnnotations" type="bool"/>
@@ -90,6 +92,21 @@
 			</hbox>
 		</groupbox>
 		
+		<groupbox id="zotero-prefpane-reader-groupbox">
+			<caption label="&zotero.preferences.pdfReader;"/>
+			
+			<hbox align="center">
+				<label value="&zotero.preferences.reader.tabsTitle.label;" control="reader-tabs-title"/>
+				<menulist id="reader-tabs-title"
+						preference="pref-reader-tabs-title">
+					<menupopup>
+						<menuitem label="&zotero.preferences.reader.tabsTitle.titleCreatorYear;" value="titleCreatorYear"/>
+						<menuitem label="&zotero.preferences.reader.tabsTitle.creatorYearTitle;" value="creatorYearTitle"/>
+					</menupopup>
+				</menulist>
+			</hbox>
+		</groupbox>
+		
 		<groupbox>
 			<caption label="&zotero.preferences.groups;"/>
 			
diff --git a/chrome/locale/en-US/zotero/preferences.dtd b/chrome/locale/en-US/zotero/preferences.dtd
index 3b081d7ed6..42c2e84296 100644
--- a/chrome/locale/en-US/zotero/preferences.dtd
+++ b/chrome/locale/en-US/zotero/preferences.dtd
@@ -26,6 +26,11 @@
 <!ENTITY zotero.preferences.trashAutoEmptyDaysPre		"Automatically remove items in the trash deleted more than">
 <!ENTITY zotero.preferences.trashAutoEmptyDaysPost		"days ago">
 
+<!ENTITY zotero.preferences.pdfReader                          "PDF Reader">
+<!ENTITY zotero.preferences.reader.tabsTitle.label             "Show tabs as">
+<!ENTITY zotero.preferences.reader.tabsTitle.creatorYearTitle  "Creator - Year - Title">
+<!ENTITY zotero.preferences.reader.tabsTitle.titleCreatorYear  "Title - Creator - Year">
+
 <!ENTITY zotero.preferences.groups						"Groups">
 <!ENTITY zotero.preferences.groups.whenCopyingInclude	"When copying items between libraries, include:">
 <!ENTITY zotero.preferences.groups.childNotes			"child notes">