scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-10-01 02:01:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix row contents shifting when showing a between-rows drop indicator
Some checks are pending
CI / Detect changes (push) Waiting to run
Details
CI / Utilities Tests (push) Waiting to run
Details
CI / Build, Upload (push) Waiting to run
Details
CI / Test () (push) Blocked by required conditions
Details
CI / Test (macOS NFS) (push) Blocked by required conditions
Details
CI / Test (Windows arm64) (push) Blocked by required conditions
Details
CI / Test (Windows x64) (push) Blocked by required conditions
Details

Browse source 
The drop indicator span was inserted before the cells, so the first
cell stopped matching :first-child and picked up inline-start padding.
Insert it after the cells instead.

Regression from 5ca1fbb167, which replaced the .first-column class with
:first-child.
This commit is contained in:
Dan Stillman 2026-09-16 15:38:34 -04:00
parent 1d4b8bc89a
commit c30163ed90
1 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
chrome/content/zotero/itemTree.jsx
View file

@ -2250,6 +2250,17 @@ var ItemTree = class ItemTree extends LibraryTree {
div.classList.remove('tight');
}
let { firstColumn } = columns.reduce((acc, column) => {
return !column.hidden && column.ordinal < acc.lowestOrdinal
? { lowestOrdinal: column.ordinal, firstColumn: column }
: acc;
}, { lowestOrdinal: Infinity, firstColumn: null });
this._renderCtx.firstColumn = firstColumn;
this._renderCtx.includeTrashed = this.rowProvider.includeTrashed;
row.renderRow(div, index, columns, rowData, this._renderCtx);
if (this._dropRow == index) {
let span;
if (Zotero.DragDrop.currentOrientation != 0) {
@ -2262,17 +2273,6 @@ var ItemTree = class ItemTree extends LibraryTree {
}
}
let { firstColumn } = columns.reduce((acc, column) => {
return !column.hidden && column.ordinal < acc.lowestOrdinal
? { lowestOrdinal: column.ordinal, firstColumn: column }
: acc;
}, { lowestOrdinal: Infinity, firstColumn: null });
this._renderCtx.firstColumn = firstColumn;
this._renderCtx.includeTrashed = this.rowProvider.includeTrashed;
row.renderRow(div, index, columns, rowData, this._renderCtx);
if (!oldDiv) {
if (this.props.dragAndDrop && row.isDraggable) {
div.setAttribute('draggable', true);