scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-10-22 05:24:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Only deproxify duplicate lookup URLs when proxy matches

Browse source 
Proxy.toProper() normalizes non-matching URLs through new URL().href, which appends a trailing slash to bare host URLs (https://example.com -> https://example.com/). Since the duplicate lookup matches stored URLs by exact equality, a translator-supplied canonical URL that does not actually match the proxy scheme would be looked up under the normalized form and silently miss the existing item. Only call toProper() when the proxy regexp actually matches the URL; otherwise keep the URL as the translator supplied it.
This commit is contained in:
Shallow 2026-07-04 07:30:33 +08:00
parent 5d65c64ea1
commit c2da119dc0
No known key found for this signature in database
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
chrome/content/zotero/xpcom/server/server_connector.js
View file

@ -340,7 +340,14 @@ Zotero.Server.Connector._getItemIdentifiers = function (data) {
let addURL = (url) => {
if (proxy && url) {
try {
url = proxy.toProper(url);
// Only deproxify when the proxy regexp actually matches.
// toProper() normalizes non-matching URLs through new URL().href,
// which can break exact-match lookups against values stored from
// the translator (e.g. https://example.com vs https://example.com/).
let normalized = new URL(url).href;
if (proxy.regexp.test(normalized)) {
url = proxy.toProper(normalized);
}
}
catch (e) {
Zotero.debug(`Could not deproxify item URL for duplicate lookup: ${e.message}`);