From b98efe0b6731493fe1b63ed33bfbba762b420470 Mon Sep 17 00:00:00 2001
From: Dan Stillman <dstillman@zotero.org>
Date: Fri, 7 Jul 2023 01:18:05 -0400
Subject: [PATCH] Remove ZoteroPane.updateTagsBoxSize()

Disabled several years ago in bb5075e8b8
---
 chrome/content/zotero/zoteroPane.js    | 23 -----------------------
 chrome/content/zotero/zoteroPane.xhtml |  4 ++--
 2 files changed, 2 insertions(+), 25 deletions(-)

diff --git a/chrome/content/zotero/zoteroPane.js b/chrome/content/zotero/zoteroPane.js
index 0d6fe02296..8a503baa4d 100644
--- a/chrome/content/zotero/zoteroPane.js
+++ b/chrome/content/zotero/zoteroPane.js
@@ -111,7 +111,6 @@ var ZoteroPane = new function()
 			let tabsDeck = document.querySelector('#tabs-deck')
 			if (!tabsDeck || tabsDeck.getAttribute('selectedIndex') == 0) {
 				this.updateToolbarPosition();
-				this.updateTagsBoxSize();
 			}
 		});
 		window.setTimeout(this.updateToolbarPosition.bind(this), 0);
@@ -6126,7 +6125,6 @@ var ZoteroPane = new function()
 		}
 
 		this.updateToolbarPosition();
-		this.updateTagsBoxSize();
 		if (ZoteroPane.itemsView) {
 			// Need to immediately rerender the items here without any debouncing
 			// since tree height will have changed
@@ -6275,27 +6273,6 @@ var ZoteroPane = new function()
 		this.handleTagSelectorResize();
 	}
 	
-	/**
-	 * Set an explicit height on the tags list to show a scroll bar if necessary
-	 *
-	 * This really should be be possible via CSS alone, but I couldn't get it to work, either
-	 * because I was doing something wrong or because the XUL layout engine was messing with me.
-	 * Revisit when we're all HTML.
-	 */
-	this.updateTagsBoxSize = function () {
-		// TODO: We can probably remove this function
-		return;
-		var pane = document.querySelector('#zotero-item-pane');
-		var header = document.querySelector('#zotero-item-pane .tags-box-header');
-		var list = document.querySelector('#zotero-item-pane .tags-box-list');
-		if (pane && header && list) {
-			let height = pane.getBoundingClientRect().height
-				- header.getBoundingClientRect().height
-				- 35; // a little padding
-			list.style.height = height + 'px';
-		}
-	};
-
 	/**
 	 * Opens the about dialog
 	 */
diff --git a/chrome/content/zotero/zoteroPane.xhtml b/chrome/content/zotero/zoteroPane.xhtml
index 206308b6a8..4177e1c8e3 100644
--- a/chrome/content/zotero/zoteroPane.xhtml
+++ b/chrome/content/zotero/zoteroPane.xhtml
@@ -1029,8 +1029,8 @@
 									</hbox>
 				
 									<splitter id="zotero-items-splitter" resizebefore="closest" resizeafter="closest" collapse="after" orient="horizontal" zotero-persist="state orient"
-										onmousemove="ZoteroPane.updateToolbarPosition(); ZoteroPane.updateTagsBoxSize()"
-										oncommand="ZoteroPane.updateToolbarPosition(); ZoteroPane.updateTagsBoxSize()">
+										onmousemove="ZoteroPane.updateToolbarPosition()"
+										oncommand="ZoteroPane.updateToolbarPosition()">
 										<grippy id="zotero-items-grippy"/>
 									</splitter>