From b15313fc3e234c04cd91522f42077d37b23bc1e5 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Tue, 2 Jan 2024 07:47:15 -0500 Subject: [PATCH] Fix "Manage Attachments" menu being disabled incorrectly We were originally going to put it in the File menu, and its disabled state was only being updated when the File menu was opened after selecting an item instead of the Tools menu. But we shouldn't actually disable it anyway, only its contents (which we're doing elsewhere), so just take this out. --- chrome/content/zotero/standalone/standalone.js | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/chrome/content/zotero/standalone/standalone.js b/chrome/content/zotero/standalone/standalone.js index ff9aae741a..cb9e4e7e5e 100644 --- a/chrome/content/zotero/standalone/standalone.js +++ b/chrome/content/zotero/standalone/standalone.js @@ -296,19 +296,6 @@ const ZoteroStandalone = new function() { }; this.onFileMenuOpen = function () { - var active = false; - try { - let zp = Zotero.getActiveZoteroPane(); - if (zp) { - active = !!zp.getSelectedItems().filter((item) => { - return item.isAttachment() - || (item.isRegularItem() && item.getAttachments().length); - }).length; - } - } - catch (e) {} - this.updateMenuItemEnabled('manage-attachments-menu', active); - // PDF annotation transfer ("Import Annotation"/"Store Annotations in File") let reader = Zotero.Reader.getByTabID(Zotero_Tabs.selectedID); if (reader) {