From ac19cbbc402ba06e779026e0929e6058a5b64d2d Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Sun, 3 May 2020 20:04:58 -0400 Subject: [PATCH] Fix tag selector not showing child item tags in "Title, Creator, Year" mode Regression from 5.0.83. This reverts 4290f26d7cf. https://forums.zotero.org/discussion/82564/tag-management --- chrome/content/zotero/xpcom/collectionTreeRow.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/chrome/content/zotero/xpcom/collectionTreeRow.js b/chrome/content/zotero/xpcom/collectionTreeRow.js index b4043eb3c1..57f282dfd8 100644 --- a/chrome/content/zotero/xpcom/collectionTreeRow.js +++ b/chrome/content/zotero/xpcom/collectionTreeRow.js @@ -336,6 +336,7 @@ Zotero.CollectionTreeRow.prototype.getSearchObject = Zotero.Promise.coroutine(fu // Library root if (this.isLibrary(true)) { s.addCondition('noChildren', 'true'); + // Allow tag selector to match child items in "Title, Creator, Year" mode includeScopeChildren = true; } else if (this.isCollection()) { @@ -344,6 +345,7 @@ Zotero.CollectionTreeRow.prototype.getSearchObject = Zotero.Promise.coroutine(fu if (Zotero.Prefs.get('recursiveCollections')) { s.addCondition('recursive', 'true'); } + // Allow tag selector to match child items in "Title, Creator, Year" mode includeScopeChildren = true; } else if (this.isPublications()) { @@ -364,10 +366,6 @@ Zotero.CollectionTreeRow.prototype.getSearchObject = Zotero.Promise.coroutine(fu if (this.isTrash()) { s2.addCondition('deleted', 'true'); } - // Don't search child items in "Title, Creator, Year" mode - if (Zotero.Prefs.get('search.quicksearch-mode') == 'titleCreatorYear') { - includeScopeChildren = false; - } s2.setScope(s, includeScopeChildren); if (this.searchText) {