From a9d7a08a05a61badbae76a8c58fdba7225ee0fbc Mon Sep 17 00:00:00 2001 From: Abe Jellinek Date: Mon, 28 Mar 2022 13:24:59 -0700 Subject: [PATCH] Fix merge interface doubling rows in master selector Master choices would occasionally be doubled in the listbox. Clearing the innerHTML instead of using removeItemAt() fixes the issue. --- chrome/content/zotero/duplicatesMerge.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/chrome/content/zotero/duplicatesMerge.js b/chrome/content/zotero/duplicatesMerge.js index 94c0d38a6b..0388f4acdd 100644 --- a/chrome/content/zotero/duplicatesMerge.js +++ b/chrome/content/zotero/duplicatesMerge.js @@ -89,10 +89,7 @@ var Zotero_Duplicates_Pane = new function () { if (alternatives) { // Populate menulist with Date Added values from all items var dateList = document.getElementById('zotero-duplicates-merge-original-date'); - - while (dateList.itemCount) { - dateList.removeItemAt(0); - } + dateList.innerHTML = ''; var numRows = 0; for (let item of items) {