From a37dd2462a4ea0a306280de49bb0fa8716dedfd5 Mon Sep 17 00:00:00 2001
From: Abe Jellinek <jellinek@berkeley.edu>
Date: Tue, 23 Jan 2024 12:05:48 -0500
Subject: [PATCH] Disable error reporting in Scaffold

---
 chrome/content/scaffold/scaffold.js       |  6 ++---
 chrome/content/zotero/RemoteTranslate.jsm | 28 +++++++++++++++--------
 2 files changed, 21 insertions(+), 13 deletions(-)

diff --git a/chrome/content/scaffold/scaffold.js b/chrome/content/scaffold/scaffold.js
index 7ae333bd3a..3bff2b030d 100644
--- a/chrome/content/scaffold/scaffold.js
+++ b/chrome/content/scaffold/scaffold.js
@@ -1000,7 +1000,7 @@ var Scaffold = new function () {
 		let translate;
 		let isRemoteWeb = false;
 		if (functionToRun == "detectWeb" || functionToRun == "doWeb") {
-			translate = new RemoteTranslate();
+			translate = new RemoteTranslate({ disableErrorReporting: true });
 			isRemoteWeb = true;
 			if (!_testTargetRegex(input)) {
 				_logOutput("Target did not match " + _getCurrentURI(input));
@@ -1703,7 +1703,7 @@ var Scaffold = new function () {
 		let input = await _getInput(type);
 
 		if (type == "web") {
-			let translate = new RemoteTranslate();
+			let translate = new RemoteTranslate({ disableErrorReporting: true });
 			try {
 				await translate.setBrowser(_browser);
 				await translate.setTranslatorProvider(_translatorProvider);
@@ -2074,7 +2074,7 @@ var Scaffold = new function () {
 					_logOutput("Page URL differs from test. Will be updated. " + browser.currentURI.spec);
 				}
 
-				let translate = new RemoteTranslate();
+				let translate = new RemoteTranslate({ disableErrorReporting: true });
 				try {
 					await translate.setBrowser(browser);
 					await translate.setTranslatorProvider(_translatorProvider);
diff --git a/chrome/content/zotero/RemoteTranslate.jsm b/chrome/content/zotero/RemoteTranslate.jsm
index 8536ddbb39..9e66e29440 100644
--- a/chrome/content/zotero/RemoteTranslate.jsm
+++ b/chrome/content/zotero/RemoteTranslate.jsm
@@ -52,7 +52,9 @@ class RemoteTranslate {
 	
 	_wasSuccess = false;
 	
-	constructor() {
+	constructor({ disableErrorReporting = false } = {}) {
+		this._disableErrorReporting = disableErrorReporting;
+		
 		TranslationManager.add(this._id, this);
 		TranslationManager.setHandler(this._id, 'done', (_, success) => this._wasSuccess = success);
 	}
@@ -64,18 +66,24 @@ class RemoteTranslate {
 	async setBrowser(browser) {
 		this._browser = browser;
 		let actor = this._browser.browsingContext.currentWindowGlobal.getActor("Translation");
+
+		// Make only relevant prefs available
+		// https://github.com/zotero/zotero-connectors/blob/d5f025de9b4f513535cbf4639c6b59bf115d790d/src/common/zotero.js#L264-L265
+		let prefs = this._getPrefs([
+			'downloadAssociatedFiles',
+			'automaticSnapshots',
+			'reportTranslationFailure',
+			'capitalizeTitles',
+			'translators.',
+		]);
+		if (this._disableErrorReporting) {
+			prefs.reportTranslationFailure = false;
+		}
+		
 		await actor.sendAsyncMessage("initTranslation", {
 			schemaJSON: Zotero.File.getResource('resource://zotero/schema/global/schema.json'),
 			dateFormatsJSON: Zotero.File.getResource('resource://zotero/schema/dateFormats.json'),
-			// Make only relevant prefs available
-			// https://github.com/zotero/zotero-connectors/blob/d5f025de9b4f513535cbf4639c6b59bf115d790d/src/common/zotero.js#L264-L265
-			prefs: this._getPrefs([
-				'downloadAssociatedFiles',
-				'automaticSnapshots',
-				'reportTranslationFailure',
-				'capitalizeTitles',
-				'translators.',
-			]),
+			prefs,
 		});
 	}