scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-08-28 05:25:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix zero local data object versions (#6016)

Browse source 
(cherry picked from commit b8fdee865a)
This commit is contained in:
Maximilian Schmidt 2026-08-13 17:23:05 +02:00 • committed by Dan Stillman
parent 4f5b05f0a4
commit a1be174c28
4 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
chrome/content/zotero/xpcom/data/collection.js
View file

@ -140,6 +140,7 @@ Zotero.Collection.prototype.loadFromRow = function (row) {
// Integer or 0
case 'version':
case 'clientVersion':
val = val ? parseInt(val) : 0;
break;

1
chrome/content/zotero/xpcom/data/item.js
View file

@ -375,6 +375,7 @@ Zotero.Item.prototype._parseRowData = function (row) {
// Integer or 0
case 'version':
case 'clientVersion':
val = val ? parseInt(val) : 0;
break;

1
chrome/content/zotero/xpcom/data/search.js
View file

@ -143,6 +143,7 @@ Zotero.Search.prototype.loadFromRow = function (row) {
// Integer or 0
case 'version':
case 'clientVersion':
val = val ? parseInt(val) : 0;
break;

15
test/tests/dataObjectTest.js
View file

@ -61,6 +61,21 @@ describe("Zotero.DataObject", function () {
}
});
it("should load 0 as a number", async function () {
for (let type of types) {
let objectsClass = Zotero.DataObjectUtilities.getObjectsClassForObjectType(type);
let obj = await createDataObject(type);
let id = obj.id;
await Zotero.DB.queryAsync(
`UPDATE ${objectsClass.table} SET clientVersion=0 WHERE ${objectsClass.idColumn}=?`,
id
);
objectsClass.unload(id);
obj = await objectsClass.getAsync(id);
assert.strictEqual(obj.clientVersion, 0, type + " clientVersion mismatch");
}
});
it("should increase after modifying object", async function () {
for (let type of types) {
let obj = await createDataObject(type);