scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-09-11 22:51:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

trim openUrl custom input, match against resolvers

Browse source 
- trim openURL input as it is being updated
- on input, load resolvers if needed
- when resolvers are loaded, check if the input matches any of them.
If so - update the dropdown with resolver's label
This commit is contained in:
Bogdan Abaev 2024-09-27 12:18:29 -07:00
parent c59c8cbffe
commit a17e8fa998
1 changed files with 28 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
chrome/content/zotero/preferences/preferences_general.js
View file

@ -345,7 +345,7 @@ Zotero_Preferences.General = {
}
var openURLMenu = document.getElementById('openurl-menu');
let openURLMenuFirstItem = openURLMenu.menupopup.firstChild;
if (!this._openURLResolvers) {
if (!this._openURLResolvers?.length) {
openURLMenuFirstItem.setAttribute('label', Zotero.getString('general.loading'));
try {
this._openURLResolvers = await Zotero.Utilities.Internal.OpenURL.getResolvers();
@ -493,10 +493,33 @@ Zotero_Preferences.General = {
},
onOpenURLCustomized: function () {
// Change resolver preference to "custom"
let firstItem = document.getElementById('openurl-menu').menupopup.firstChild;
firstItem.setAttribute('label', Zotero.getString('general.custom'));
firstItem.setAttribute('value', 'custom');
let opeUrlInput = document.getElementById("openURLServerField");
let openUrlMenu = document.getElementById('openurl-menu').menupopup.firstChild;
// Remove trailing whitespaces
opeUrlInput.value = opeUrlInput.value.trim();
// If resolvers have been fetched, see if there is one that matches the input
if (this._openURLResolvers?.length) {
let inputMatchedResolved = this._openURLResolvers.find(resolver => resolver.url == opeUrlInput.value);
if (inputMatchedResolved) {
// User typed the url of an existing resolver, so update the name and dropdown label
Zotero.Prefs.set('openURL.name', inputMatchedResolved.name);
openUrlMenu.setAttribute('label', inputMatchedResolved.name);
return;
}
}
// If the resolvers have not been loaded, fetch them
else if (!this._openURLResolvers?.promise) {
// Save the promise so we don't request resolvers multiple times as the user types
this._openURLResolvers = Zotero.Promise.defer();
Zotero.Utilities.Internal.OpenURL.getResolvers().then((res) => {
this._openURLResolvers = res;
// Rerun so that if the user pastes a url, we still check if it matches loaded resolvers above
this.onOpenURLCustomized();
});
}
// Change resolver preference to "custom" if we did not find a matching resolver above
openUrlMenu.setAttribute('label', Zotero.getString('general.custom'));
openUrlMenu.setAttribute('value', 'custom');
Zotero.Prefs.clear('openURL.name');
},