scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-08-28 05:25:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix ZoteroPane tests failing intermittently

Browse source
This commit is contained in:
Adomas Venčkauskas 2026-04-21 14:44:07 +03:00
parent e1cd83214f
commit 9abd13fd22
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
test/tests/zoteroPaneTest.js
View file

@ -1473,10 +1473,14 @@ describe("ZoteroPane", function () {
for (let id of sequence) {
// Set up focus listener before dispatching the event
// to avoid racing against async focus from setTimeout
// to avoid racing against async focus from setTimeout.
// Use "focusin" rather than "focus" because the target is a XUL
// <search-textbox> whose real focus target is an anonymous inner
// <input>; "focus" does not bubble, so a listener on the outer
// element would never fire.
let focusPromise;
if (id === "zotero-collections-search") {
focusPromise = waitForDOMEvent(doc.getElementById(id), "focus");
focusPromise = waitForDOMEvent(doc.getElementById(id), "focusin");
}
// Set up hide observer before the shift-tab that blurs collection-search
let hidePromise;
@ -1516,10 +1520,12 @@ describe("ZoteroPane", function () {
let reversed = [...sequence].reverse();
for (let id of reversed) {
// Set up focus listener before dispatching the event
// to avoid racing against async focus from setTimeout
// to avoid racing against async focus from setTimeout.
// See the shift-tab test above for why this listens on "focusin"
// rather than "focus".
let focusPromise;
if (id === "zotero-collections-search") {
focusPromise = waitForDOMEvent(doc.getElementById(id), "focus");
focusPromise = waitForDOMEvent(doc.getElementById(id), "focusin");
}
doc.activeElement.dispatchEvent(tab);
if (focusPromise) {