From 8aeb6f7fe41b255d1e5381451664fa67e9735e7f Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Sat, 28 Sep 2019 06:16:19 -0400 Subject: [PATCH] Mark fields as changed when migrating Extra fields We're not migrating fields yet, but when we do, I think marking them as changed will be the safer option. We'll just have to make sure that conflicts without differences are resolved automatically on all platforms. --- chrome/content/zotero/xpcom/schema.js | 7 ------- 1 file changed, 7 deletions(-) diff --git a/chrome/content/zotero/xpcom/schema.js b/chrome/content/zotero/xpcom/schema.js index ce7292af21..63b0d693fc 100644 --- a/chrome/content/zotero/xpcom/schema.js +++ b/chrome/content/zotero/xpcom/schema.js @@ -622,13 +622,6 @@ Zotero.Schema = new function(){ for (let item of items) { let changed = item.migrateExtraFields(); if (!changed) continue; - // Don't mark the item as changed if it's not already so that every client doesn't try - // to upload new data. While in theory the changes should be the same and automatically - // merged, it's risky and unnecessary, since server data will also be updated on schema - // changes. (It would also create a huge amount of write traffic.) - if (item.synced) { - item.synced = true; - } await item.saveTx({ skipDateModifiedUpdate: true, skipSelect: true