From 81c6c8deff8d881e42eb3cfb4afca5b0532df3ad Mon Sep 17 00:00:00 2001
From: Martynas Bagdonas <git.martynas@gmail.com>
Date: Tue, 11 Oct 2022 18:06:10 +0300
Subject: [PATCH] Add annotation update test to pdf-reader tests

---
 test/tests/pdfReaderTest.js | 98 +++++++++++++++++++++++++++++++++++--
 1 file changed, 94 insertions(+), 4 deletions(-)

diff --git a/test/tests/pdfReaderTest.js b/test/tests/pdfReaderTest.js
index 6b7ac8f982..d87050692c 100644
--- a/test/tests/pdfReaderTest.js
+++ b/test/tests/pdfReaderTest.js
@@ -13,8 +13,60 @@ describe("PDF Reader", function () {
 	});
 
 	describe('Reader', function () {
-		it('should create annotations', async function () {
+		it('should create/update annotations', async function () {
 			var attachment = await importFileAttachment('test.pdf');
+
+			// Existing highlight annotation
+			await Zotero.Annotations.saveFromJSON(attachment, {
+				key: 'AAAAAAAA',
+				type: 'highlight',
+				color: '#ffd400',
+				sortIndex: '00000|003305|00000',
+				position: {
+					pageIndex: 0,
+					rects: [[0, 0, 100, 100]]
+				}
+			});
+
+			// Existing note annotation
+			await Zotero.Annotations.saveFromJSON(attachment, {
+				key: 'BBBBBBBB',
+				type: 'note',
+				color: '#ffd400',
+				sortIndex: '00000|003305|00000',
+				position: {
+					pageIndex: 0,
+					rects: [[0, 0, 100, 100]]
+				}
+			});
+
+			// Existing image annotation
+			await Zotero.Annotations.saveFromJSON(attachment, {
+				key: 'CCCCCCCC',
+				type: 'image',
+				color: '#ffd400',
+				sortIndex: '00000|003305|00000',
+				comment: 'asdf',
+				position: {
+					pageIndex: 0,
+					rects: [[0, 0, 100, 100]]
+				}
+			});
+
+			// Existing ink annotation
+			await Zotero.Annotations.saveFromJSON(attachment, {
+				key: 'DDDDDDDD',
+				type: 'ink',
+				color: '#ffd400',
+				sortIndex: '00000|003305|00000',
+				position: {
+					pageIndex: 0,
+					paths: [[517.759, 760.229]],
+					width: 2,
+					unknownField: 'test'
+				},
+			});
+
 			var reader = await Zotero.Reader.open(attachment.itemID);
 			// TODO: Implement a promise that would be resolved when pdf-reader is completely loaded
 			var n = 0;
@@ -22,6 +74,8 @@ describe("PDF Reader", function () {
 				await Zotero.Promise.delay(100);
 			}
 			await reader._iframeWindow.wrappedJSObject.viewerInstance._viewer._pdfjsPromise;
+
+			// Create highlight annotation
 			await reader._iframeWindow.wrappedJSObject.viewerInstance._viewer._annotationsStore.addAnnotation(
 				Components.utils.cloneInto({
 					type: 'highlight',
@@ -34,6 +88,8 @@ describe("PDF Reader", function () {
 					text: 'test'
 				}, reader._iframeWindow)
 			);
+
+			// Create note annotation
 			await reader._iframeWindow.wrappedJSObject.viewerInstance._viewer._annotationsStore.addAnnotation(
 				Components.utils.cloneInto({
 					type: 'note',
@@ -47,6 +103,8 @@ describe("PDF Reader", function () {
 					text: 'test'
 				}, reader._iframeWindow)
 			);
+
+			// Create image annotation
 			await reader._iframeWindow.wrappedJSObject.viewerInstance._viewer._annotationsStore.addAnnotation(
 				Components.utils.cloneInto({
 					type: 'image',
@@ -59,12 +117,44 @@ describe("PDF Reader", function () {
 					}
 				}, reader._iframeWindow)
 			);
+
+			// Update 4 items
+			await reader._iframeWindow.wrappedJSObject.viewerInstance._viewer._annotationsStore.updateAnnotations(
+				Components.utils.cloneInto([
+					{
+						id: 'AAAAAAAA',
+						text: 'test'
+					},
+					{
+						id: 'BBBBBBBB',
+						color: '#aabbcc'
+					},
+					{
+						id: 'CCCCCCCC',
+						comment: 'test'
+					},
+					{
+						id: 'DDDDDDDD',
+						position: { pageIndex: 2 }
+					},
+				], reader._iframeWindow)
+			);
+
 			// TODO: Try to avoid pdf-reader annotation saving debounce which is now 1000ms
 			await Zotero.Promise.delay(1500);
 			var annotations = attachment.getAnnotations();
-			assert.equal(annotations.length, 3);
-		});
 
-		// TODO: Add annotation update and deletion tests
+			// 4 existing + 3 created
+			assert.equal(annotations.length, 7);
+
+			// Test 4 updated annotations
+			assert.equal(annotations.find(x => x.key === 'AAAAAAAA').annotationText, 'test');
+			assert.equal(annotations.find(x => x.key === 'BBBBBBBB').annotationColor, '#aabbcc');
+			assert.equal(annotations.find(x => x.key === 'CCCCCCCC').annotationComment, 'test');
+			// Test updated position pageIndex, and make sure unknownField is preserved
+			assert.equal(JSON.parse(annotations.find(x => x.key === 'DDDDDDDD').annotationPosition).pageIndex, 2);
+			assert.equal(JSON.parse(annotations.find(x => x.key === 'DDDDDDDD').annotationPosition).unknownField, 'test');
+			reader.close();
+		});
 	});
 });