From 7b34f22ddf8ca3e5ee4ed8f639675b369b8eb11d Mon Sep 17 00:00:00 2001 From: Michael Swift Date: Thu, 11 Jun 2026 12:59:15 -0400 Subject: [PATCH] Add regression tests for connector save-session gc and remove() Cover the three previously-broken behaviors: gc() expiring sessions past the TTL, gc() retaining fresh sessions, and SaveSession#remove() deleting a session from the manager. There was no existing coverage of gc(), which is how the leak went unnoticed. --- test/tests/server_connectorTest.js | 35 ++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/test/tests/server_connectorTest.js b/test/tests/server_connectorTest.js index e5223f7051..92dd662d63 100644 --- a/test/tests/server_connectorTest.js +++ b/test/tests/server_connectorTest.js @@ -93,6 +93,41 @@ describe("Connector Server", function () { }); }); + describe("SaveSession.SessionManager", function () { + var SessionManager = Zotero.Server.Connector.SessionManager; + + it("should expire sessions older than the TTL when gc() runs", function () { + var id = "gcOld_" + Zotero.Utilities.randomString(); + var session = SessionManager.create(id, 'saveItems', {}); + // Backdate creation beyond the 10-minute TTL + session.created = new Date(Date.now() - 11 * 60 * 1000); + + SessionManager.gc(); + + assert.isUndefined(SessionManager.get(id), "stale session should be removed by gc()"); + }); + + it("should keep sessions newer than the TTL when gc() runs", function () { + var id = "gcNew_" + Zotero.Utilities.randomString(); + var session = SessionManager.create(id, 'saveItems', {}); + + SessionManager.gc(); + + assert.strictEqual(SessionManager.get(id), session, "fresh session should survive gc()"); + session.remove(); + }); + + it("should remove a session via SaveSession#remove()", function () { + var id = "remove_" + Zotero.Utilities.randomString(); + var session = SessionManager.create(id, 'saveItems', {}); + assert.strictEqual(SessionManager.get(id), session); + + session.remove(); + + assert.isUndefined(SessionManager.get(id), "remove() should delete the session from the manager"); + }); + }); + describe('/connector/getTranslatorCode', function () { it('should respond with translator code', async function () { var code = 'function detectWeb() {}\nfunction doImport() {}';