From 794cbaee2cda5a92b58fd2a099eab57c0683e5e2 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Tue, 24 Oct 2006 23:40:04 +0000 Subject: [PATCH] Decidedly not the time to make changes of this magnitude, but ids in the global overlay really need to be namespaced properly to avoid conflicts with other extensions (These aren't all in the global overlay, but the ones that aren't at least share a CSS rule with elements that are.) --- chrome/content/zotero/addCitationDialog.xul | 20 +++--- chrome/content/zotero/bindings/noteeditor.xml | 4 +- chrome/content/zotero/bindings/relatedbox.xml | 4 +- chrome/content/zotero/bindings/tagsbox.xml | 4 +- .../content/zotero/bindings/zoterosearch.xml | 4 +- chrome/content/zotero/itemPane.js | 46 +++++++------- chrome/content/zotero/itemPane.xul | 32 +++++----- chrome/content/zotero/overlay.js | 40 ++++++------ chrome/content/zotero/overlay.xul | 61 +++++++++---------- chrome/content/zotero/selectItemsDialog.js | 8 +-- chrome/content/zotero/selectItemsDialog.xul | 20 +++--- .../zotero/xpcom/collectionTreeView.js | 2 +- chrome/content/zotero/xpcom/itemTreeView.js | 26 ++++---- chrome/skin/default/zotero/overlay.css | 56 ++++++++--------- chrome/skin/default/zotero/zotero.css | 34 +++++------ 15 files changed, 180 insertions(+), 181 deletions(-) diff --git a/chrome/content/zotero/addCitationDialog.xul b/chrome/content/zotero/addCitationDialog.xul index c8104167e6..92a69ca749 100644 --- a/chrome/content/zotero/addCitationDialog.xul +++ b/chrome/content/zotero/addCitationDialog.xul @@ -44,19 +44,19 @@ - - @@ -64,27 +64,27 @@ - diff --git a/chrome/content/zotero/bindings/noteeditor.xml b/chrome/content/zotero/bindings/noteeditor.xml index a63e3b13ff..6abded6fee 100644 --- a/chrome/content/zotero/bindings/noteeditor.xml +++ b/chrome/content/zotero/bindings/noteeditor.xml @@ -186,8 +186,8 @@ - - + + diff --git a/chrome/content/zotero/bindings/relatedbox.xml b/chrome/content/zotero/bindings/relatedbox.xml index 0090902e76..a55bb518e5 100644 --- a/chrome/content/zotero/bindings/relatedbox.xml +++ b/chrome/content/zotero/bindings/relatedbox.xml @@ -106,7 +106,7 @@ var box = document.createElement('box'); box.setAttribute('onclick',"this.parentNode.parentNode.parentNode.parentNode.parentNode.showItem('"+seealso[i].getID()+"')"); - box.setAttribute('class','clicky'); + box.setAttribute('class','zotero-clicky'); box.setAttribute('flex','1'); box.appendChild(icon); box.appendChild(label); @@ -114,7 +114,7 @@ var remove = document.createElement("label"); remove.setAttribute('value','-'); remove.setAttribute('onclick',"this.parentNode.parentNode.parentNode.parentNode.parentNode.remove('"+seealso[i].getID()+"');"); - remove.setAttribute('class','clicky'); + remove.setAttribute('class','zotero-clicky'); var row = document.createElement("row"); row.appendChild(box); diff --git a/chrome/content/zotero/bindings/tagsbox.xml b/chrome/content/zotero/bindings/tagsbox.xml index 5f20cf317e..b1f5a2e6c3 100644 --- a/chrome/content/zotero/bindings/tagsbox.xml +++ b/chrome/content/zotero/bindings/tagsbox.xml @@ -120,12 +120,12 @@ { remove.setAttribute('tabindex', -1); remove.setAttribute('onclick',"this.parentNode.parentNode.parentNode.parentNode.parentNode.remove('"+id+"');"); - remove.setAttribute('class','clicky'); + remove.setAttribute('class','zotero-clicky'); } else { remove.setAttribute('disabled', true); - remove.setAttribute('class', 'unclicky'); + remove.setAttribute('class', 'zotero-unclicky'); } var row = document.createElement("row"); diff --git a/chrome/content/zotero/bindings/zoterosearch.xml b/chrome/content/zotero/bindings/zoterosearch.xml index 7f00e1a994..757ef4b671 100644 --- a/chrome/content/zotero/bindings/zoterosearch.xml +++ b/chrome/content/zotero/bindings/zoterosearch.xml @@ -436,8 +436,8 @@ - - + + diff --git a/chrome/content/zotero/itemPane.js b/chrome/content/zotero/itemPane.js index 6b3149966d..328adc4854 100644 --- a/chrome/content/zotero/itemPane.js +++ b/chrome/content/zotero/itemPane.js @@ -84,15 +84,15 @@ var ZoteroItemPane = new function() return false; } - _dynamicFields = document.getElementById('editpane-dynamic-fields'); - _itemTypeMenu = document.getElementById('editpane-type-menu'); - _creatorTypeMenu = document.getElementById('creatorTypeMenu'); - _notesList = document.getElementById('editpane-dynamic-notes'); - _notesLabel = document.getElementById('editpane-notes-label'); - _attachmentsList = document.getElementById('editpane-dynamic-attachments'); - _attachmentsLabel = document.getElementById('editpane-attachments-label'); - _tagsBox = document.getElementById('editpane-tags'); - _relatedBox = document.getElementById('editpane-related'); + _dynamicFields = document.getElementById('zotero-editpane-dynamic-fields'); + _itemTypeMenu = document.getElementById('zotero-editpane-type-menu'); + _creatorTypeMenu = document.getElementById('zotero-creator-type-menu'); + _notesList = document.getElementById('zotero-editpane-dynamic-notes'); + _notesLabel = document.getElementById('zotero-editpane-notes-label'); + _attachmentsList = document.getElementById('zotero-editpane-dynamic-attachments'); + _attachmentsLabel = document.getElementById('zotero-editpane-attachments-label'); + _tagsBox = document.getElementById('zotero-editpane-tags'); + _relatedBox = document.getElementById('zotero-editpane-related'); var itemTypes = Zotero.ItemTypes.getTypes(); for(var i = 0; i" (OpenURL) button switch (_itemBeingEdited.getType()) @@ -203,7 +203,7 @@ var ZoteroItemPane = new function() default: var openURL = false; } - document.getElementById('tb-openurl').setAttribute('disabled', !openURL); + document.getElementById('zotero-tb-openurl').setAttribute('disabled', !openURL); // Clear and rebuild creator type menu while(_creatorTypeMenu.hasChildNodes()) @@ -308,13 +308,13 @@ var ZoteroItemPane = new function() var box = document.createElement('box'); box.setAttribute('onclick',"ZoteroPane.selectItem("+notes[i].getID()+");"); - box.setAttribute('class','clicky'); + box.setAttribute('class','zotero-clicky'); box.appendChild(icon); box.appendChild(label); var removeButton = document.createElement('label'); removeButton.setAttribute("value","-"); - removeButton.setAttribute("class","clicky"); + removeButton.setAttribute("class","zotero-clicky"); removeButton.setAttribute("onclick","ZoteroItemPane.removeNote("+notes[i].getID()+")"); var row = document.createElement('row'); @@ -366,13 +366,13 @@ var ZoteroItemPane = new function() var box = document.createElement('box'); box.setAttribute('onclick',"ZoteroPane.selectItem('"+attachments[i].getID()+"')"); - box.setAttribute('class','clicky'); + box.setAttribute('class','zotero-clicky'); box.appendChild(icon); box.appendChild(label); var removeButton = document.createElement('label'); removeButton.setAttribute("value","-"); - removeButton.setAttribute("class","clicky"); + removeButton.setAttribute("class","zotero-clicky"); removeButton.setAttribute("onclick","ZoteroItemPane.removeAttachment("+attachments[i].getID()+")"); var row = document.createElement('row'); @@ -475,9 +475,9 @@ var ZoteroItemPane = new function() var label = document.createElement("toolbarbutton"); label.setAttribute("label",Zotero.getString('creatorTypes.'+Zotero.CreatorTypes.getName(typeID))+":"); label.setAttribute("typeid", typeID); - label.setAttribute("popup","creatorTypeMenu"); + label.setAttribute("popup","zotero-creator-type-menu"); label.setAttribute("fieldname",'creator-'+_creatorCount+'-typeID'); - label.className = 'clicky'; + label.className = 'zotero-clicky'; // getCreatorFields(), switchCreatorMode() and handleCreatorAutoCompleteSelect() // may need need to be adjusted if this DOM structure changes @@ -519,7 +519,7 @@ var ZoteroItemPane = new function() // Single/double field toggle var toggleButton = document.createElement('toolbarbutton'); toggleButton.setAttribute('fieldname', 'creator-' + _creatorCount + '-singleField'); - toggleButton.className = 'clicky'; + toggleButton.className = 'zotero-clicky'; hbox.appendChild(toggleButton); // Minus (-) button @@ -530,7 +530,7 @@ var ZoteroItemPane = new function() disableButton(removeButton); } else { - removeButton.setAttribute("class","clicky"); + removeButton.setAttribute("class","zotero-clicky"); removeButton.setAttribute("onclick","ZoteroItemPane.removeCreator("+_creatorCount+", this.parentNode.parentNode)"); } hbox.appendChild(removeButton); @@ -675,14 +675,14 @@ var ZoteroItemPane = new function() function disableButton(button) { button.setAttribute('disabled', true); - button.setAttribute('class', 'unclicky'); + button.setAttribute('class', 'zotero-unclicky'); button.setAttribute('onclick', false); } function _enablePlusButton(button, creatorTypeID, fieldMode) { button.setAttribute('disabled', false); - button.setAttribute("class","clicky"); + button.setAttribute("class","zotero-clicky"); button.setAttribute("onclick", "ZoteroItemPane.disableButton(this); ZoteroItemPane.addCreatorRow('', '', " + (creatorTypeID ? creatorTypeID : 'false') + ", " + fieldMode + ", true);"); } @@ -703,7 +703,7 @@ var ZoteroItemPane = new function() valueElement.setAttribute('fieldname',fieldName); valueElement.setAttribute('tabindex', tabindex); valueElement.setAttribute('onclick', 'ZoteroItemPane.showEditor(this)'); - valueElement.className = 'clicky'; + valueElement.className = 'zotero-clicky'; switch (fieldName) { diff --git a/chrome/content/zotero/itemPane.xul b/chrome/content/zotero/itemPane.xul index f418dd067a..ce3f9ff386 100644 --- a/chrome/content/zotero/itemPane.xul +++ b/chrome/content/zotero/itemPane.xul @@ -29,7 +29,7 @@ - - @@ -85,10 +85,10 @@ - + - - + + \ No newline at end of file diff --git a/chrome/content/zotero/overlay.js b/chrome/content/zotero/overlay.js index 9afe16d017..92f097e388 100644 --- a/chrome/content/zotero/overlay.js +++ b/chrome/content/zotero/overlay.js @@ -88,22 +88,22 @@ var ZoteroPane = new function() appContent.removeChild(oldSplitter); appContent.insertBefore(newSplitter, document.getElementById('content')); - document.getElementById('tb-fullscreen').setAttribute('zoterotop','true'); + document.getElementById('zotero-tb-fullscreen').setAttribute('zoterotop','true'); } //Initialize collections view collectionsView = new Zotero.CollectionTreeView(); - var collectionsTree = document.getElementById('collections-tree'); + var collectionsTree = document.getElementById('zotero-collections-tree'); collectionsTree.view = collectionsView; collectionsTree.controllers.appendController(new Zotero.CollectionTreeCommandController(collectionsTree)); - var itemsTree = document.getElementById('items-tree'); + var itemsTree = document.getElementById('zotero-items-tree'); itemsTree.controllers.appendController(new Zotero.ItemTreeCommandController(itemsTree)); // Create the New Item (+) menu with each item type - var addMenu = document.getElementById('tb-add').firstChild; - var separator = document.getElementById('tb-add').firstChild.firstChild; - var moreMenu = document.getElementById('tb-add-more'); + var addMenu = document.getElementById('zotero-tb-add').firstChild; + var separator = document.getElementById('zotero-tb-add').firstChild.firstChild; + var moreMenu = document.getElementById('zotero-tb-add-more'); var itemTypes = Zotero.ItemTypes.getPrimaryTypes(); for(var i = 0; i - + - - - + + + - + @@ -91,7 +91,7 @@ - @@ -108,9 +108,9 @@ - + - + @@ -118,23 +118,23 @@ - + - + - - - + + + - @@ -188,9 +183,9 @@ - + - + @@ -203,7 +198,7 @@ - + diff --git a/chrome/content/zotero/selectItemsDialog.js b/chrome/content/zotero/selectItemsDialog.js index 48d5a40402..036230124f 100644 --- a/chrome/content/zotero/selectItemsDialog.js +++ b/chrome/content/zotero/selectItemsDialog.js @@ -34,7 +34,7 @@ function doLoad() io = window.arguments[0]; collectionsView = new Zotero.CollectionTreeView(); - document.getElementById('collections-tree').view = collectionsView; + document.getElementById('zotero-collections-tree').view = collectionsView; // move to center of screen window.sizeToContent(); @@ -62,7 +62,7 @@ function onCollectionSelected() collection.setSearch(''); itemsView = new Zotero.ItemTreeView(collection, (window.arguments[1] ? true : false)); - document.getElementById('items-tree').view = itemsView; + document.getElementById('zotero-items-tree').view = itemsView; } } @@ -71,10 +71,10 @@ function onSearch() { if(itemsView) { - var searchVal = document.getElementById('tb-search').value; + var searchVal = document.getElementById('zotero-tb-search').value; itemsView.searchText(searchVal); - document.getElementById('tb-search-cancel').hidden = searchVal == ""; + document.getElementById('zotero-tb-search-cancel').hidden = searchVal == ""; } } diff --git a/chrome/content/zotero/selectItemsDialog.xul b/chrome/content/zotero/selectItemsDialog.xul index df2be7ee29..7303f32aac 100644 --- a/chrome/content/zotero/selectItemsDialog.xul +++ b/chrome/content/zotero/selectItemsDialog.xul @@ -41,19 +41,19 @@