From 769bfbc892e617b12a938783eb6bedd8486768b8 Mon Sep 17 00:00:00 2001 From: Martynas Bagdonas Date: Tue, 15 Mar 2022 09:53:11 +0200 Subject: [PATCH] Fix PDF reader up/down keyboard navigation regression in RTL mode --- chrome/content/zotero/zoteroPane.js | 10 ++++++---- pdf-reader | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/chrome/content/zotero/zoteroPane.js b/chrome/content/zotero/zoteroPane.js index 1d6ae02fda..edb8ef0aeb 100644 --- a/chrome/content/zotero/zoteroPane.js +++ b/chrome/content/zotero/zoteroPane.js @@ -519,14 +519,16 @@ var ZoteroPane = new function() let itemPaneToggle = document.getElementById('zotero-tb-toggle-item-pane'); let notesPaneToggle = document.getElementById('zotero-tb-toggle-notes-pane'); // Using ArrowDown and ArrowUp to be consistent with pdf-reader - if (!Zotero.rtl && (event.key === 'ArrowRight' || event.key === 'ArrowDown') - || Zotero.rtl && (event.key === 'ArrowLeft' || event.key === 'ArrowUp')) { + if (!Zotero.rtl && event.key === 'ArrowRight' + || Zotero.rtl && event.key === 'ArrowLeft' + || event.key === 'ArrowDown') { if (event.target === itemPaneToggle) { notesPaneToggle.focus(); } } - else if (!Zotero.rtl && (event.key === 'ArrowLeft' || event.key === 'ArrowUp') - || Zotero.rtl && (event.key === 'ArrowRight' || event.key === 'ArrowDown')) { + else if (!Zotero.rtl && event.key === 'ArrowLeft' + || Zotero.rtl && event.key === 'ArrowRight' + || event.key === 'ArrowUp') { if (event.target === notesPaneToggle) { itemPaneToggle.focus(); } diff --git a/pdf-reader b/pdf-reader index 702fd99ca5..cca2dcbe5c 160000 --- a/pdf-reader +++ b/pdf-reader @@ -1 +1 @@ -Subproject commit 702fd99ca58801be27b25ee550331b9615f27184 +Subproject commit cca2dcbe5ce1d4566bb6cd28f18c19c030e0c80a