From 7306fe910d609613bb5c6bc0bd82c6a4e39a7bb9 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Fri, 14 Jun 2019 23:53:43 -0400 Subject: [PATCH] Fix updating of Next button in RTFScan (regression from 269e2f8bff) And fix a logged warning --- chrome/content/zotero/rtfScan.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/chrome/content/zotero/rtfScan.js b/chrome/content/zotero/rtfScan.js index 71e61c9a82..0efb4aa3d5 100644 --- a/chrome/content/zotero/rtfScan.js +++ b/chrome/content/zotero/rtfScan.js @@ -428,7 +428,7 @@ var Zotero_RTFScan = new function() { var io = {singleSelection:true}; if(citationItemIDs[citation] && citationItemIDs[citation].length == 1) { // mapped citation // specify that item should be selected in window - io.select = citationItemIDs[citation]; + io.select = citationItemIDs[citation][0]; } window.openDialog('chrome://zotero/content/selectItemsDialog.xul', '', 'chrome,modal', io); @@ -460,7 +460,8 @@ var Zotero_RTFScan = new function() { */ function _refreshCanAdvance() { var canAdvance = true; - for (let itemList of citationItemIDs) { + for (let i in citationItemIDs) { + let itemList = citationItemIDs[i]; if(itemList.length != 1) { canAdvance = false; break;