From 63a8d2b8c48de1a6cd92fff54ecea59ef5dee80a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adomas=20Ven=C4=8Dkauskas?= Date: Mon, 6 May 2019 14:57:42 +0300 Subject: [PATCH] Fix citeproc preview call citationsPre/post arrays --- chrome/content/zotero/xpcom/integration.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/chrome/content/zotero/xpcom/integration.js b/chrome/content/zotero/xpcom/integration.js index 871e2c46e7..4b153ce616 100644 --- a/chrome/content/zotero/xpcom/integration.js +++ b/chrome/content/zotero/xpcom/integration.js @@ -1222,17 +1222,17 @@ Zotero.Integration.Fields.prototype.addEditCitation = async function (field) { var previewFn = async function (citation) { let idx = await fieldIndexPromise; await citationsByItemIDPromise; - var fields = await this.get(); - var [citations, fieldToCitationIdxMapping, citationToFieldIdxMapping] = this._session.getCiteprocLists(true); + var [citations, fieldToCitationIdxMapping, citationToFieldIdxMapping] = this._session.getCiteprocLists(); for (var prevIdx = idx-1; prevIdx >= 0; prevIdx--) { if (prevIdx in fieldToCitationIdxMapping) break; } - for (var nextIdx = idx; nextIdx < fields.length; nextIdx++) { - if (nextIdx in fieldToCitationIdxMapping) break; + let sliceIdx = fieldToCitationIdxMapping[prevIdx]+1; + if (sliceIdx == NaN) { + sliceIdx = 0; } - let citationsPre = citations.slice(0, fieldToCitationIdxMapping[prevIdx]+1); - let citationsPost = citations.slice(fieldToCitationIdxMapping[nextIdx]); + let citationsPre = citations.slice(0, sliceIdx); + let citationsPost = citations.slice(sliceIdx); let citationID = citation.citationID; try { var result = this._session.style.previewCitationCluster(citation, citationsPre, citationsPost, "rtf");