From 60fd0829b0958e7ba5aaf595a0b38e33ebb1cd3d Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Tue, 23 Apr 2024 04:26:42 -0400 Subject: [PATCH] fx-compat: Fix positioning and size of progress popups In Firefox 115, overwriting `outerHeight` caused it to not report the correct value later, and whatever issue were were working around seems to have been resolved since Firefox 3. https://forums.zotero.org/discussion/113633/zotero-7-beta-bug-report-the-progresswindow-shows-at-incorrect-position --- chrome/content/zotero/progressWindow.xhtml | 2 +- chrome/content/zotero/xpcom/progressWindow.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/chrome/content/zotero/progressWindow.xhtml b/chrome/content/zotero/progressWindow.xhtml index 4ef8e574d9..db1fce57f0 100644 --- a/chrome/content/zotero/progressWindow.xhtml +++ b/chrome/content/zotero/progressWindow.xhtml @@ -35,7 +35,7 @@ title="&zotero.progress.title;" no-titlebar-icon="true" drawintitlebar-platforms="win,linux" - width="300" + style="min-width: 300px" windowtype="alert:alert"> diff --git a/chrome/content/zotero/xpcom/progressWindow.js b/chrome/content/zotero/xpcom/progressWindow.js index d46ca914d1..c3fd44742f 100644 --- a/chrome/content/zotero/xpcom/progressWindow.js +++ b/chrome/content/zotero/xpcom/progressWindow.js @@ -45,6 +45,9 @@ Zotero.ProgressWindowSet = new function() { } + /** + * @progressWin {Window} - DOM Window + */ function tile(progressWin) { var parent = progressWin.opener; var y_sub = null; @@ -477,9 +480,6 @@ Zotero.ProgressWindow = function(options = {}) { } function _move() { - // sizeToContent() fails in FF3 with multiple lines - // if we don't change the height - _progressWindow.outerHeight = _progressWindow.outerHeight + 1; _progressWindow.sizeToContent(); Zotero.ProgressWindowSet.tile(_progressWindow); }