From 5d65c64ea13550cfec0e63c0dedfab9b5f51a711 Mon Sep 17 00:00:00 2001 From: Shallow Date: Sat, 4 Jul 2026 07:09:56 +0800 Subject: [PATCH] Simplify duplicate lookup DOI match guard The Array.prototype.find() predicate already guarantees a non-empty DOI present in doiSet, so the extra doiSet.has() check in the following if-condition is redundant. --- chrome/content/zotero/xpcom/server/server_connector.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chrome/content/zotero/xpcom/server/server_connector.js b/chrome/content/zotero/xpcom/server/server_connector.js index 20a4d8d405..019f2aa721 100644 --- a/chrome/content/zotero/xpcom/server/server_connector.js +++ b/chrome/content/zotero/xpcom/server/server_connector.js @@ -504,7 +504,7 @@ Zotero.Server.Connector.findExistingItemsByIdentifiers = async function (identif item.getField('DOI'), item.getExtraField('DOI') ].map(doi => Zotero.Utilities.cleanDOI(doi)).find(doi => doi && doiSet.has(doi.toLowerCase())); - if (itemDOI && doiSet.has(itemDOI.toLowerCase())) { + if (itemDOI) { matchedFields.push('DOI'); matchedIdentifiers.doi = itemDOI; }