From 5c95c35743bddaca9b850e62494c360d72fe9108 Mon Sep 17 00:00:00 2001 From: Abe Jellinek Date: Mon, 25 Aug 2025 12:43:34 -0400 Subject: [PATCH] Style installation: Don't prompt on validation error in silent mode --- chrome/content/zotero/xpcom/style.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/chrome/content/zotero/xpcom/style.js b/chrome/content/zotero/xpcom/style.js index 902f154d1f..1297390dc4 100644 --- a/chrome/content/zotero/xpcom/style.js +++ b/chrome/content/zotero/xpcom/style.js @@ -445,11 +445,11 @@ Zotero.Styles = new function () { .catch(function (validationErrors) { Zotero.logError("Style from " + origin + " failed to validate:\n\n" + validationErrors); - // If validation fails on the parent of a dependent style, ignore it (for now) - if(hidden) return; + // If this is the parent of a dependent style, or if we're in + // silent mode, suppress the prompt + if (hidden || silent) return; - // If validation fails on a different style, we ask the user if s/he really - // wants to install it + // Otherwise, ask the user whether to continue installing var shouldInstall = Services.prompt.confirmEx(null, Zotero.getString('styles.install.title'), Zotero.getString('styles.validationWarning', [origin, Zotero.appName]),