From 5ae1986f797230ea4bcecc10409a60a57e86c1d1 Mon Sep 17 00:00:00 2001
From: Abe Jellinek <jellinek@berkeley.edu>
Date: Thu, 6 Mar 2025 10:20:13 -0500
Subject: [PATCH] renderItemTitle(): Fix nested tag handling when rendering to
 string

Need to exit the loop regardless of whether we're rendering actual
nodes.

Fixes #5082
---
 chrome/content/zotero/xpcom/utilities_internal.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/chrome/content/zotero/xpcom/utilities_internal.js b/chrome/content/zotero/xpcom/utilities_internal.js
index dd7a1516ff..a1847ebf2a 100644
--- a/chrome/content/zotero/xpcom/utilities_internal.js
+++ b/chrome/content/zotero/xpcom/utilities_internal.js
@@ -2465,12 +2465,14 @@ Zotero.Utilities.Internal = {
 							let discardedNode = nodeStack.pop();
 							if (discardedMarkup.beginsTag === markup.endsTag) {
 								nodeStack[nodeStack.length - 1].append(discardedNode);
-								break;
 							}
 							else {
 								nodeStack[nodeStack.length - 1].append(discardedMarkup.token, ...discardedNode.childNodes);
 							}
 						}
+						if (discardedMarkup.beginsTag === markup.endsTag) {
+							break;
+						}
 					}
 
 					continue;