From 59aaf8dfef8712f7021dee168442cdbb076e938e Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Mon, 12 Oct 2026 23:08:50 -0400 Subject: [PATCH] Fix "Hide" label sticking on the collection context menu's Delete item After the menu was built for a hideable row (My Publications, Unfiled Items, etc.), the Delete Collection/Search item kept showing "Hide" for collections and saved searches. Set "Hide" via Fluent like the other labels. https://forums.zotero.org/discussion/134097/ --- chrome/content/zotero/zoteroPane.js | 4 ++-- chrome/locale/en-US/zotero/zotero.ftl | 3 +++ chrome/locale/en-US/zotero/zotero.properties | 1 - 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/chrome/content/zotero/zoteroPane.js b/chrome/content/zotero/zoteroPane.js index 51ae8d4ece..46a7bfb01a 100644 --- a/chrome/content/zotero/zoteroPane.js +++ b/chrome/content/zotero/zoteroPane.js @@ -4094,14 +4094,14 @@ var ZoteroPane = new function () { show.push('clearAllLastRead'); } - m.deleteCollection.setAttribute('label', Zotero.getString('general.hide')); + document.l10n.setAttributes(m.deleteCollection, 'collections-menu-hide'); useHideOrDelete = "hide"; } else if (collectionTreeRows[0].isHeader()) { } else if (collectionTreeRows[0].isPublications()) { show = ['exportFile', 'deleteCollection']; - m.deleteCollection.setAttribute('label', Zotero.getString('general.hide')); + document.l10n.setAttributes(m.deleteCollection, 'collections-menu-hide'); useHideOrDelete = "hide"; } // Library diff --git a/chrome/locale/en-US/zotero/zotero.ftl b/chrome/locale/en-US/zotero/zotero.ftl index 33e621eb52..9a3fb4634d 100644 --- a/chrome/locale/en-US/zotero/zotero.ftl +++ b/chrome/locale/en-US/zotero/zotero.ftl @@ -66,6 +66,7 @@ general-copy = Copy general-paste = Paste general-find = Find general-delete = Delete +general-hide = Hide general-insert = Insert general-and = and general-et-al = et al. @@ -276,6 +277,8 @@ collections-menu-delete-search = [one] Delete Search… *[other] Delete Searches… } +collections-menu-hide = + .label = { general-hide } collections-delete-title = { $count -> diff --git a/chrome/locale/en-US/zotero/zotero.properties b/chrome/locale/en-US/zotero/zotero.properties index fc3e3d899b..bf615726ad 100644 --- a/chrome/locale/en-US/zotero/zotero.properties +++ b/chrome/locale/en-US/zotero/zotero.properties @@ -56,7 +56,6 @@ general.enable = Enable general.disable = Disable general.remove = Remove general.reset = Reset -general.hide = Hide general.quit = Quit general.useDefault = Use Default general.openDocumentation = Open Documentation