scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-10-05 02:43:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Always use Zotero.CreatorTypes.getLocalizedString()

Browse source 
Since some strings are now stored in schema.ftl

https://forums.zotero.org/discussion/128757/z8-beta-films-dont-have-any-creator-types
This commit is contained in:
Dan Stillman 2025-12-30 14:28:56 -05:00
parent c6ef23a650
commit 58baa44ad4
2 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
chrome/content/zotero/elements/itemBox.js
View file

@ -688,7 +688,7 @@
var localized = {};
for (let i = 0; i < creatorTypes.length; i++) {
localized[creatorTypes[i].name]
= Zotero.getString('creatorTypes.' + creatorTypes[i].name);
= Zotero.CreatorTypes.getLocalizedString(creatorTypes[i].name);
}
for (let i in localized) {
@ -1159,7 +1159,7 @@
rowLabel.appendChild(labelWrapper);
let label = this.createLabelElement({
id: 'creator-type-label-inner',
text: Zotero.getString('creatorTypes.' + Zotero.CreatorTypes.getName(typeID)),
text: Zotero.CreatorTypes.getLocalizedString(typeID),
skipEventHandlers: true,
});
labelWrapper.appendChild(label);
@ -2845,9 +2845,8 @@
var row = typeBox.parentNode;
var fields = this.getCreatorFields(row);
fields.creatorTypeID = typeID;
typeBox.querySelector("#creator-type-label-inner").textContent = Zotero.getString(
'creatorTypes.' + Zotero.CreatorTypes.getName(typeID)
);
typeBox.querySelector("#creator-type-label-inner").textContent
= Zotero.CreatorTypes.getLocalizedString(typeID);
typeBox.setAttribute('typeid', typeID);
this.modifyCreator(index, fields);

2
chrome/content/zotero/xpcom/report.js
View file

@ -167,7 +167,7 @@ Zotero.Report.HTML = new function () {
content += '\t\t\t\t\t<tr>\n';
content += '\t\t\t\t\t\t<th class="' + creator.creatorType + '">'
+ escapeXML(Zotero.getString('creatorTypes.' + creator.creatorType))
+ escapeXML(Zotero.CreatorTypes.getLocalizedString(creator.creatorType))
+ '</th>\n';
content += '\t\t\t\t\t\t<td>' + escapeXML(displayText) + '</td>\n';
content += '\t\t\t\t\t</tr>\n';