From 57573961975df4eb89f2f4f85f72ab60b8ed33e4 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Mon, 17 Aug 2026 12:10:35 -0400 Subject: [PATCH] Fix changelog URL generation for two-digit major versions The short version was derived from the first three characters of the version string, so 10.0 produced a detailsURL of "10._changelog". --- app/scripts/add_version_info | 3 ++- app/scripts/build_for_deploy | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/app/scripts/add_version_info b/app/scripts/add_version_info index 68320b108f..1d5690aa15 100755 --- a/app/scripts/add_version_info +++ b/app/scripts/add_version_info @@ -4,6 +4,7 @@ Update a builds manifest with info on a given build """ import argparse import os +import re import sys import shutil import json @@ -25,7 +26,7 @@ def main(): try: file = args.file version = args.version - short_version = version[0:3] + short_version = re.match(r'\d+\.\d+', version).group(0) # Back up JSON file shutil.copy2(file, file + '.bak') diff --git a/app/scripts/build_for_deploy b/app/scripts/build_for_deploy index ec65012da1..1f9db44ade 100755 --- a/app/scripts/build_for_deploy +++ b/app/scripts/build_for_deploy @@ -144,7 +144,7 @@ chmod g+ws "$TEMP_DIR/version_info" cp "$DIST_DIR"/files-* "$TEMP_DIR/version_info" chmod g+w "$TEMP_DIR"/version_info/files-* # Generate build-{os}.json for each platform -SHORT_VERSION="${VERSION:0:3}" +SHORT_VERSION=$(echo "$VERSION" | grep -oE '^[0-9]+\.[0-9]+') DETAILS_URL="https://www.zotero.org/support/${SHORT_VERSION}_changelog" for i in `seq 0 1 $((${#PLATFORMS}-1))` do