scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-10-05 02:43:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Use real PMCID field instead of Extra fallback

Browse source 
PMCID is a real, auto-migrated field, so the getExtraField() fallback
isn't needed.
This commit is contained in:
Dan Stillman 2026-06-15 14:33:24 -04:00
parent 9fb88bf087
commit 51aed56d66
3 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
chrome/content/zotero/xpcom/attachments.js
View file

@ -1239,7 +1239,7 @@ Zotero.Attachments = new function () {
this.canFindFileForItem = function (item) {
let pmcid = item.getField('PMCID') || item.getExtraField('PMCID');
let pmcid = item.getField('PMCID');
return item.isRegularItem()
&& !item.isFeedItem
&& (!!item.getField('DOI') || !!item.getField('url') || !!item.getExtraField('DOI') || !!pmcid)
@ -1276,7 +1276,7 @@ Zotero.Attachments = new function () {
var resolvers = [];
var doi = item.getField('DOI') || item.getExtraField('DOI');
var pmcid = item.getField('PMCID') || item.getExtraField('PMCID');
var pmcid = item.getField('PMCID');
doi = Zotero.Utilities.cleanDOI(doi);
if (pmcid) {
let matches = pmcid.match(/\bPMC\d+\b/i);

10
test/tests/attachmentsTest.js
View file

@ -1031,10 +1031,10 @@ describe("Zotero.Attachments", function () {
assert.equal(await OS.File.stat(attachment.getFilePath()).size, pdfSize);
});
it("should include a PubMed Central resolver from a PMCID in Extra", async function () {
it("should include a PubMed Central resolver from a PMCID", async function () {
var item = createUnsavedDataObject('item', { itemType: 'journalArticle' });
item.setField('title', 'Test');
item.setField('extra', 'PMCID: PMC9262588');
item.setField('PMCID', 'PMC9262588');
await item.saveTx();
var resolvers = Zotero.Attachments.getFileResolvers(item, ['oa']);
@ -1051,7 +1051,7 @@ describe("Zotero.Attachments", function () {
var item = createUnsavedDataObject('item', { itemType: 'journalArticle' });
item.setField('title', 'Test');
item.setField('DOI', '10.1093/nar/gkac173');
item.setField('extra', 'PMCID: PMC9262588');
item.setField('PMCID', 'PMC9262588');
await item.saveTx();
var resolvers = Zotero.Attachments.getFileResolvers(item, ['oa']);
@ -1064,10 +1064,10 @@ describe("Zotero.Attachments", function () {
assert.isFunction(resolvers[1]);
});
it("should allow finding files for an item with a PMCID in Extra", async function () {
it("should allow finding files for an item with a PMCID", async function () {
var item = createUnsavedDataObject('item', { itemType: 'journalArticle' });
item.setField('title', 'Test');
item.setField('extra', 'PMCID: PMC9262588');
item.setField('PMCID', 'PMC9262588');
await item.saveTx();
assert.isTrue(Zotero.Attachments.canFindFileForItem(item));

4
test/tests/server_connectorTest.js
View file

@ -701,7 +701,7 @@ describe("Connector Server", function () {
assert.isTrue(JSON.parse(response.responseText));
});
it("should respond with 'true' if the item has a PMCID fallback", async function () {
it("should respond with 'true' if the item has a PMCID", async function () {
const sessionID = Zotero.Utilities.randomString();
const itemID = Zotero.Utilities.randomString();
const body = {
@ -711,7 +711,7 @@ describe("Connector Server", function () {
id: itemID,
itemType: "journalArticle",
title: "Test Article with PMCID",
extra: "PMCID: PMC9262588",
PMCID: "PMC9262588",
}
]
};