From 4eb47417950399b1bd3c4eeb78c0cd2fe7badf76 Mon Sep 17 00:00:00 2001 From: Abe Jellinek Date: Wed, 26 Jun 2024 11:17:17 -0400 Subject: [PATCH] Prevent pinning Notes button in reader sidenav Sidenav button pane IDs usually correspond to sections with the same IDs, but `context-notes` actually corresponds to two sections (`context-all-notes` and `context-item-notes`). We were preventing those sections from being pinned, but not the button that reveals them. Fixes #4283 --- chrome/content/zotero/elements/itemPaneSidenav.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chrome/content/zotero/elements/itemPaneSidenav.js b/chrome/content/zotero/elements/itemPaneSidenav.js index 34554a4fc5..54fcad116f 100644 --- a/chrome/content/zotero/elements/itemPaneSidenav.js +++ b/chrome/content/zotero/elements/itemPaneSidenav.js @@ -187,7 +187,7 @@ } isPanePinnable(id) { - return id !== 'info' && id !== 'context-all-notes' && id !== 'context-item-notes'; + return id !== 'info' && id !== 'context-notes' && id !== 'context-all-notes' && id !== 'context-item-notes'; } init() {