From 4a15b2633a6d0aed5bdcc3974425a75d33a73bf8 Mon Sep 17 00:00:00 2001
From: Abe Jellinek <jellinek@berkeley.edu>
Date: Fri, 1 Dec 2023 10:22:31 -0500
Subject: [PATCH] Remove section title highlight on sidenav click

---
 chrome/content/zotero/elements/itemPaneSidenav.js | 11 -----------
 scss/elements/_collapsibleSection.scss            |  5 -----
 2 files changed, 16 deletions(-)

diff --git a/chrome/content/zotero/elements/itemPaneSidenav.js b/chrome/content/zotero/elements/itemPaneSidenav.js
index 3b76e3193e..945727fba2 100644
--- a/chrome/content/zotero/elements/itemPaneSidenav.js
+++ b/chrome/content/zotero/elements/itemPaneSidenav.js
@@ -133,16 +133,6 @@
 			pane.focus();
 		}
 		
-		_flashPane(id) {
-			let paneSection = this.getPane(id)?.querySelector('collapsible-section');
-			if (paneSection) {
-				paneSection.classList.add('highlight');
-				setTimeout(() => {
-					paneSection.classList.remove('highlight');
-				}, 1000);
-			}
-		}
-		
 		_makeSpaceForPane(pane) {
 			let oldMinScrollHeight = this._minScrollHeight;
 			let newMinScrollHeight = this._getMinScrollHeightForPane(pane);
@@ -197,7 +187,6 @@
 					switch (event.detail) {
 						case 1:
 							this.scrollToPane(pane, 'smooth');
-							this._flashPane(pane);
 							break;
 						case 2:
 							if (this.pinnedPane == pane || !pinnable) {
diff --git a/scss/elements/_collapsibleSection.scss b/scss/elements/_collapsibleSection.scss
index f3ddd53a6d..7417e3ec7c 100644
--- a/scss/elements/_collapsibleSection.scss
+++ b/scss/elements/_collapsibleSection.scss
@@ -24,7 +24,6 @@ collapsible-section {
 			gap: 4px;
 			color: var(--fill-secondary);
 			font-weight: 590;
-			transition: color 0.2s ease-out;
 
 			&::before {
 				content: '';
@@ -66,10 +65,6 @@ collapsible-section {
 		}
 	}
 	
-	&.highlight > .head > .title {
-		color: var(--fill-primary);
-	}
-	
 	&[open]:not([empty]) > .head {
 		toolbarbutton.twisty .toolbarbutton-icon {
 			transform: rotate(-180deg);