From 49fe2b98d97523174889ec86b9925e4e795ca034 Mon Sep 17 00:00:00 2001
From: Abe Jellinek <jellinek@berkeley.edu>
Date: Tue, 16 Jan 2024 11:48:50 -0500
Subject: [PATCH] Restore tag autocomplete popup

Regression from 275ea6f because of a duplicate element ID. Now we only create
one popup, even if there are multiple tags-boxes.
---
 chrome/content/zotero/elements/tagsBox.js | 32 ++++++++++++++---------
 1 file changed, 19 insertions(+), 13 deletions(-)

diff --git a/chrome/content/zotero/elements/tagsBox.js b/chrome/content/zotero/elements/tagsBox.js
index 4b67e55956..aa42cac348 100644
--- a/chrome/content/zotero/elements/tagsBox.js
+++ b/chrome/content/zotero/elements/tagsBox.js
@@ -48,19 +48,6 @@
 							<menupopup id="tags-context-menu">
 								<menuitem id="remove-all-item-tags" label="&zotero.item.tags.removeAll;"/>
 							</menupopup>
-							<!-- Note: autocomplete-input can create this panel by itself, but it appears
-									   in the top DOM and is behind the tags box popup -->
-							<panel
-								is="autocomplete-richlistbox-popup"
-								type="autocomplete-richlistbox"
-								id="PopupAutoComplete"
-								role="group"
-								noautofocus="true"
-								hidden="true"
-								overflowpadding="4"
-								norolluponanchor="true"
-								nomaxresults="true"
-							/>
 						</popupset>
 					</html:div>
 				</collapsible-section>
@@ -88,6 +75,25 @@
 				removeAllItemTags.disabled = !this.count;
 				this._id('tags-context-menu').openPopupAtScreen(event.screenX, event.screenY, true);
 			});
+			
+			if (!document.getElementById('PopupAutoComplete')) {
+				let popupset = document.querySelector('popupset');
+				if (!popupset) {
+					popupset = document.createXULElement('popupset');
+					document.documentElement.append(popupset);
+				}
+				
+				let autocomplete = document.createXULElement('panel', { is: 'autocomplete-richlistbox-popup' });
+				autocomplete.id = 'PopupAutoComplete';
+				autocomplete.setAttribute('type', 'autocomplete-richlistbox');
+				autocomplete.setAttribute('role', 'group');
+				autocomplete.setAttribute('noautofocus', true);
+				autocomplete.setAttribute('hidden', true);
+				autocomplete.setAttribute('overflowpadding', 4);
+				autocomplete.setAttribute('norolluponanchor', true);
+				autocomplete.setAttribute('nomaxresults', true);
+				popupset.append(autocomplete);
+			}
 
 			// Register our observer with priority 101 (after Zotero.Tags) so we get updated tag colors
 			this._notifierID = Zotero.Notifier.registerObserver(this, ['item-tag', 'setting'], 'tagsBox', 101);