From 433426086567f9c79e86d8b857b4ef444e2e1081 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Fri, 20 Jun 2014 03:14:32 -0400 Subject: [PATCH] Revert "Use Q instead of Task.spawn to run processUpdatedXML()" Fixes "Q.async(...)(...) is undefined" sync error This reverts commit ad8b81f4c7a076b07038990e766ca74482b4609e (which tried to fix Fx32+ compatibility). --- chrome/content/zotero/xpcom/sync.js | 6 ++++-- resource/q.js | 9 +-------- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/chrome/content/zotero/xpcom/sync.js b/chrome/content/zotero/xpcom/sync.js index ae10eb5a8b..4f0901d1d0 100644 --- a/chrome/content/zotero/xpcom/sync.js +++ b/chrome/content/zotero/xpcom/sync.js @@ -1627,7 +1627,9 @@ Zotero.Sync.Server = new function () { _error(e); } - Q.async(Zotero.Sync.Server.Data.processUpdatedXML( + Components.utils.import("resource://gre/modules/Task.jsm"); + + Task.spawn(Zotero.Sync.Server.Data.processUpdatedXML( responseNode.getElementsByTagName('updated')[0], lastLocalSyncDate, syncSession, @@ -1836,7 +1838,7 @@ Zotero.Sync.Server = new function () { Zotero.HTTP.doPost(url, body, uploadCallback); } } - ))() + )) .then( null, function (e) { diff --git a/resource/q.js b/resource/q.js index de32ab3923..47b3118c2f 100644 --- a/resource/q.js +++ b/resource/q.js @@ -1021,14 +1021,7 @@ function async(makeGenerator) { } return when(result, callback, errback); } - // Added by Dan - // If already a generator, use that - if (makeGenerator.send) { - var generator = makeGenerator; - } - else { - var generator = makeGenerator.apply(this, arguments); - } + var generator = makeGenerator.apply(this, arguments); var callback = continuer.bind(continuer, "send"); var errback = continuer.bind(continuer, "throw"); return callback();