From 41ba29180d8ee3786aabe5995a0793ceefe68483 Mon Sep 17 00:00:00 2001
From: Dan Stillman <dstillman@zotero.org>
Date: Thu, 31 Aug 2006 22:14:13 +0000
Subject: [PATCH] Don't disable "View Attachment" button for links, and change
 the text to "View File" or "View Link" depending on what's selected

---
 chrome/chromeFiles/content/scholar/overlay.js         | 11 ++++++++++-
 chrome/chromeFiles/content/scholar/overlay.xul        |  2 +-
 .../locale/en-US/scholar/scholar.properties           |  2 ++
 3 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/chrome/chromeFiles/content/scholar/overlay.js b/chrome/chromeFiles/content/scholar/overlay.js
index f514af8510..2c4111fdee 100644
--- a/chrome/chromeFiles/content/scholar/overlay.js
+++ b/chrome/chromeFiles/content/scholar/overlay.js
@@ -228,7 +228,16 @@ var ScholarPane = new function()
 			else if(item.isAttachment())
 			{
 				document.getElementById('scholar-attachment-label').setAttribute('value',item.getField('title'));
-				document.getElementById('scholar-attachment-view').setAttribute('disabled', item.ref.getAttachmentLinkMode() == Scholar.Attachments.LINK_MODE_LINKED_URL);
+				if (item.ref.getAttachmentLinkMode() == Scholar.Attachments.LINK_MODE_LINKED_URL
+					|| item.ref.getAttachmentLinkMode() == Scholar.Attachments.LINK_MODE_IMPORTED_URL)
+				{
+					var str = Scholar.getString('pane.item.attachments.view.link');
+				}
+				else
+				{
+					var str = Scholar.getString('pane.item.attachments.view.file');
+				}
+				document.getElementById('scholar-attachment-view').setAttribute('label', str);
 				document.getElementById('scholar-attachment-links').item = item.ref;
 				document.getElementById('item-pane').selectedIndex = 3;
 			}
diff --git a/chrome/chromeFiles/content/scholar/overlay.xul b/chrome/chromeFiles/content/scholar/overlay.xul
index aa280c41ba..e7776fcfc9 100644
--- a/chrome/chromeFiles/content/scholar/overlay.xul
+++ b/chrome/chromeFiles/content/scholar/overlay.xul
@@ -189,7 +189,7 @@
 						</vbox>
 						<vbox id="scholar-view-attachment" flex="1">
 							<label id="scholar-attachment-label"/>
-							<button id="scholar-attachment-view" label="View Attachment" oncommand="ScholarPane.viewSelectedAttachment();"/>
+							<button id="scholar-attachment-view" oncommand="ScholarPane.viewSelectedAttachment();"/>
 							<linksbox id="scholar-attachment-links" flex="1"/>
 						</vbox>
 					</deck>
diff --git a/chrome/chromeFiles/locale/en-US/scholar/scholar.properties b/chrome/chromeFiles/locale/en-US/scholar/scholar.properties
index fd6c28b3aa..72cfb17838 100644
--- a/chrome/chromeFiles/locale/en-US/scholar/scholar.properties
+++ b/chrome/chromeFiles/locale/en-US/scholar/scholar.properties
@@ -26,6 +26,8 @@ pane.item.notes.untitled        = Untitled Note
 pane.item.notes.delete.confirm  = Are you sure you want to delete this note?
 pane.item.notes.count.singular  = %1 note
 pane.item.notes.count.plural    = %1 notes
+pane.item.attachments.view.link	= View Page
+pane.item.attachments.view.file	= View File
 pane.item.attachments.delete.confirm  = Are you sure you want to delete this attachment?
 pane.item.attachments.count.singular  = %1 attachment
 pane.item.attachments.count.plural    = %1 attachments