scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-10-10 03:28:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

itemPaneTest: Scroll to attachments pane instead of relying on pin

Browse source 
The pinned pane doesn't reliably trigger a render of an out-of-view pane in
this state, so scroll to the pane the way the surrounding tests do.
This commit is contained in:
Dan Stillman 2026-07-07 16:46:10 -04:00 • committed by Dan Stillman
parent 4314494455
commit 3ae3bd41dc
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
test/tests/itemPaneTest.js
View file

@ -987,6 +987,8 @@ describe("Item pane", function () {
await item.saveTx();
await ZoteroPane.selectItem(item.id);
// Scroll to the pane, since pinning doesn't reliably render it if it's out of view
await waitForScrollToPane(itemDetails, paneID);
// Pass the item id so we don't return early due to a previous item's completed render
assert.isTrue(await waitForPreviewBoxRender(attachmentsBox, item.id));
// No preview
@ -1149,6 +1151,8 @@ describe("Item pane", function () {
let annotation = await createAnnotation('highlight', attachment1);
await itemDetails._renderPromise;
// Scroll to the pane, since pinning doesn't reliably render it if it's out of view
await waitForScrollToPane(itemDetails, paneID);
await waitForPreviewBoxReader(attachmentsBox, attachment1.id);
assert.isFalse(attachmentsBox.hidden);
@ -1175,6 +1179,7 @@ describe("Item pane", function () {
// Select item with attachment (no annotation)
await itemDetails._renderPromise;
await waitForScrollToPane(itemDetails, paneID);
await waitForPreviewBoxReader(attachmentsBox, attachment2.id);
assert.isFalse(attachmentsBox.hidden);
@ -1194,6 +1199,7 @@ describe("Item pane", function () {
// Select item without attachment
await itemDetails._renderPromise;
await waitForScrollToPane(itemDetails, paneID);
assert.isFalse(attachmentsBox.hidden);
assert.equal(attachmentsBox.querySelectorAll("attachment-row").length, 0);
@ -1201,6 +1207,7 @@ describe("Item pane", function () {
// Again, select item with attachment (1 annotation)
await ZoteroPane.selectItem(item1.id);
await itemDetails._renderPromise;
await waitForScrollToPane(itemDetails, paneID);
await waitForPreviewBoxReader(attachmentsBox, attachment1.id);
assert.isFalse(attachmentsBox.hidden);
@ -1344,10 +1351,13 @@ describe("Item pane", function () {
// Should be able to render the correct preview
await ZoteroPane.selectItem(item1.id);
// Scroll to the pane, since pinning doesn't reliably render it if it's out of view
await waitForScrollToPane(itemDetails, paneID);
await waitForPreviewBoxReader(attachmentsBox, attachment1.id);
assert.isTrue(await isPreviewDisplayed(attachmentsBox));
await ZoteroPane.selectItem(item2.id);
await waitForScrollToPane(itemDetails, paneID);
await waitForPreviewBoxReader(attachmentsBox, attachment2.id);
assert.isTrue(await isPreviewDisplayed(attachmentsBox));